Prevent modifying request by reference #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
8 times, most recently
from
7ccaa4b to
45187a2
Compare
pedrobranco
force-pushed
the
bugfix/fix-modifying-by-reference
branch
from
45187a2 to
8fc16bd
Compare
Author
|
#18 replaces this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #16 by preventing changing the module
request.In this case if the user passes the require('request') object to
request-debugit throws. It requires that the user passes an instance ofrequest.defaults(<args>).