feat: preflight support for custom lam and kots ports #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
laverya
previously approved these changes
Sep 25, 2024
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-112082/support-for-custom-lam-and-kots-ports-preflights
branch
2 times, most recently
from
8e3f2d6
to
619b68c
Compare
kots and lam ports may be customized through command line flags so we need to make preflights to reflect these customizations.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-112082/support-for-custom-lam-and-kots-ports-preflights
branch
from
b4a6a5d
to
e68ce3d
Compare
during one of the last rebases i have done i ended up overwriting the changes to the phrasing here, this commit restores it.
|
|
@ajp-io The previous recording was bogus, this is the actual thing: https://www.loom.com/share/bafc75d8e59e4dff9fd593e6b394a85d |
|
Looks great! Thanks for the Loom too. |
make the result of preflight execution a list instead of a table.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-112082/support-for-custom-lam-and-kots-ports-preflights
branch
from
035ff12
to
36ff6e6
Compare
laverya
approved these changes
Sep 26, 2024
ricardomaraschini
deleted the
ricardomaraschini/sc-112082/support-for-custom-lam-and-kots-ports-preflights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR depends on #1205 getting merged before, that is why it is a little big longer than the usual (it includes the changes from #1205).
The relevant part to be reviewed here is only the last commit (link), the review of the other commits will be done in the other PR.
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?