feat: add host preflights for all needed ports #1205
Conversation
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
pkg/preflights/host-preflight.yaml
Outdated
| outcomes: | ||
| - fail: | ||
| when: "connection-refused" | ||
| message: Port 30000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). |
There was a problem hiding this comment.
I need to better understand this one to comment on the wording, but this can be fine for now.
There was a problem hiding this comment.
For context: this means that we have been able to start listening on a given port (the port is available) but when we tried to connect to it we failed. This is an IMHO unlikely scenario.
We have discussed this personally and we came to the conclusion that this could be caused by an erroneous proxy configuration but I am not sure this is even possible as we are testing at TCP level, not HTTP. Some iptables rules may cause this though (redirecting traffic somewhere else) but again, unlikely.
pkg/preflights/host-preflight.yaml
Outdated
| message: Port 30000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). | ||
| - fail: | ||
| when: "address-in-use" | ||
| message: Port 30000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. |
There was a problem hiding this comment.
When we merge Ethan's port relocation changes, we can update this:
| message: Port 30000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. | |
| message: Port 30000/TCP is required, but another process is already listening on it. To proceed, relocate the conflicting process or specify an available port using --admin-console-port. |
pkg/preflights/host-preflight.yaml
Outdated
| message: Port 50000/TCP is required, but the connection was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). | ||
| - fail: | ||
| when: "address-in-use" | ||
| message: Port 50000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. |
There was a problem hiding this comment.
When we merge Ethan's port relocation changes, we can update this:
| message: Port 50000/TCP is required, but another process is already listening on it. Relocate the conflicting process to continue. | |
| message: Port 50000/TCP is required, but another process is already listening on it. To proceed, relocate the conflicting process or specify an available port using --local-artifact-mirror-port. |
checks if all needed ports are available on the server prior to start the installation.
make sure preflights are failing if some ports are in use.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-112082/determine-all-the-ports-that-are-needed-for
branch
from
dda5421
to
4d04007
Compare
now we reboot the node after finishing the reset command.
ricardomaraschini
force-pushed
the
ricardomaraschini/sc-112082/determine-all-the-ports-that-are-needed-for
branch
from
6339d1c
to
5de9c25
Compare
| - fail: | ||
| when: "connection-refused" | ||
| message: Connection to 2379/TCP was refused. This may indicate that the connection is being redirected to somewhere else on your network (perhaps a proxy configuration). |
There was a problem hiding this comment.
This feels really ambiguous. I can't think of a good reason to hit this other than a proxy. Should we just say the connection was refused, ensure your NO_PROXY includes this machines IP address?
Or even that, we're doing ourself now right? Can we even hit this?
There was a problem hiding this comment.
Yeah, we do that ourselves now. Maybe a more generic message like "ensure this port is available" would suffice if it's very unlikely this even occurs.
There was a problem hiding this comment.
After looking at this again I don't think even an invalid NO_PROXY configuration would cause this to happen. The collector operates at the TCP level. Are we OK with the "Please ensure this port is available" message ?
ricardomaraschini
deleted the
ricardomaraschini/sc-112082/determine-all-the-ports-that-are-needed-for
branch
What this PR does / why we need it:
Checks if all needed ports are available on the server prior to start the installation.