Skip to content

feat: Smart Sessions Ownable Validator #4602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 3, 2025
Merged

feat: Smart Sessions Ownable Validator #4602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d229092
feat: use version2 of BAPI + grantPermissions to use ownable validator
tomiir Jul 2, 2025
8d2c49e
Merge branch 'main' of github.com:reown-com/appkit into feat/ownable-…
tomiir Jul 2, 2025
cf94b03
chore: rollback bapi url
tomiir Jul 2, 2025
3f74c97
chore: rollback connect-src on middleware
tomiir Jul 2, 2025
b56088c
chore: use version 2 instead of 2.0
tomiir Jul 3, 2025
1b769c2
chore: add version parameters
tomiir Jul 3, 2025
5d2efe8
fix: test with new query param
tomiir Jul 3, 2025
fbf013d
chore: add changeset
tomiir Jul 3, 2025
9a6428b
chore: update type
tomiir Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .changeset/dark-loops-walk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
'@reown/appkit-experimental': patch
'@reown/appkit-adapter-bitcoin': patch
'@reown/appkit-adapter-ethers': patch
'@reown/appkit-adapter-ethers5': patch
'@reown/appkit-adapter-solana': patch
'@reown/appkit-adapter-wagmi': patch
'@reown/appkit': patch
'@reown/appkit-utils': patch
'@reown/appkit-cdn': patch
'@reown/appkit-cli': patch
'@reown/appkit-codemod': patch
'@reown/appkit-common': patch
'@reown/appkit-controllers': patch
'@reown/appkit-core': patch
'@reown/appkit-pay': patch
'@reown/appkit-polyfills': patch
'@reown/appkit-scaffold-ui': patch
'@reown/appkit-siwe': patch
'@reown/appkit-siwx': patch
'@reown/appkit-testing': patch
'@reown/appkit-ui': patch
'@reown/appkit-wallet': patch
'@reown/appkit-wallet-button': patch
---

Updates Smart Sessions validator with audited OwnableValidator contract by Rhinestone
11,077 changes: 905 additions & 10,172 deletions apps/laboratory/test-results.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion packages/experimental/src/smart-session/controllers/SmartSessionsController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ export const SmartSessionsController = {
}
})

const rawResponse = await connectionControllerClient?.grantPermissions([request])
const versionedRequest = { ...request, version: 2 }
const rawResponse = await connectionControllerClient?.grantPermissions([versionedRequest])

// Validate and type guard the response
const response = assertWalletGrantPermissionsResponse(rawResponse)
Expand Down
154 changes: 0 additions & 154 deletions packages/experimental/src/smart-session/grantPermissions.ts
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions packages/experimental/src/smart-session/utils/CosignerService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ export class CosignerService {
const response = await sendCoSignerRequest<
AddPermissionRequest,
AddPermissionResponse,
{ projectId: string }
{ projectId: string; v: string }
>({
url,
request: data,
queryParams: { projectId: this.projectId },
queryParams: { projectId: this.projectId, v: '2' },
headers: { 'Content-Type': 'application/json' }
})
assertAddPermissionResponse(response)
Expand Down
1 change: 1 addition & 0 deletions packages/experimental/src/smart-session/utils/TypeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export type SmartSessionGrantPermissionsRequest = {
type: string
data: Record<string, unknown>
}[]
version?: number
}

export type WalletGrantPermissionsResponse = SmartSessionGrantPermissionsRequest & {
Expand Down
2 changes: 1 addition & 1 deletion packages/experimental/tests/smart-session/CosignerService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ describe('CoSigner API Tests', () => {

const expectedUrl = `${ConstantsUtil.COSIGNER_BASE_URL}/${encodeURIComponent(
mockAddress
)}?projectId=${encodeURIComponent(projectId)}`
)}?projectId=${encodeURIComponent(projectId)}&v=2`

expect(mockFetch).toHaveBeenCalledWith(
expectedUrl,
Expand Down
Loading