Skip to content

Conversation

@tomiir
Copy link
Collaborator

@tomiir tomiir commented Jul 2, 2025

Description

  • Updates Cosigner Service addPermission to use v=2 parameter, triggering usage of OwnableValidator on Blockchain API side
  • Serializes version: '2.0' into grantPermissions request, to trigger usage of OwnableValidator secure site side.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-3003

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@linear
Copy link

linear bot commented Jul 2, 2025

@changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

🦋 Changeset detected

Latest commit: 9a6428b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@reown/appkit-experimental Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-codemod Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-pay Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-testing Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-basic-html ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 7:36pm
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 7:36pm
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2025 7:36pm
10 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Visit Preview Jul 3, 2025 7:36pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
appkit-vue-solana ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm
vue-wagmi-example ⬜️ Ignored (Inspect) Jul 3, 2025 7:36pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Warnings
⚠️

🔑 Potential High‑entropy string detected in packages/experimental/tests/smart-session/CosignerService.test.ts (line 23): 0x123456789012345678...

⚠️

🔑 Potential High‑entropy string detected in packages/experimental/tests/smart-session/CosignerService.test.ts (line 40): 0x2E65BAfA07238666c3...

⚠️

🔑 Potential High‑entropy string detected in packages/experimental/src/smart-session/utils/TypeUtils.ts (line 120): ERC20RecurringAllowa...

⚠️

🔑 Potential High‑entropy string detected in packages/experimental/src/smart-session/utils/TypeUtils.ts (line 120): ERC20RecurringAllowa...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 3): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 640): OGQxN2M4OWMtNjBkMy00...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 658): eyJBUElfS0VZIjoicGtf...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 658): eyJBUElfS0VZIjoicGtf...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): packages/wallet/dist...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): src/components/Ether...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 753): /next/dist/compiled/...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 826): eyJBUElfS0VZIjoicGtf...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 826): eyJBUElfS0VZIjoicGtf...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 838): com/sdk/goals/655380...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 841): com/sdk/evalx/655380...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 847): 3000/api/auth/callba...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/siwe/dist/e...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 847): 3000/api/auth/callba...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/siwe/dist/e...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 874): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 874): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 874): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 847): 3000/api/auth/callba...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/siwe/dist/e...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 853): packages/controllers...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 4): Users/rocky/Work/app...

⚠️

🔑 Potential High‑entropy string detected in apps/laboratory/test-results.json (line 794): Users/rocky/Work/app...

Generated by 🚫 dangerJS against 9a6428b

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.69% 30856 / 39716
🔵 Statements 77.69% 30856 / 39716
🔵 Functions 68.77% 2539 / 3692
🔵 Branches 84.26% 6407 / 7603
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/experimental/src/smart-session/controllers/SmartSessionsController.ts 62.63% 61.53% 50% 62.63% 52-56, 58-81, 89-90, 97-98, 125-126, 156-157, 165-168, 172-173, 176-178, 186-187, 195, 201-239
packages/experimental/src/smart-session/utils/CosignerService.ts 98.16% 89.28% 100% 98.16% 99-100
packages/experimental/src/smart-session/utils/TypeUtils.ts 100% 100% 100% 100%
Generated in workflow #13132 for commit 9a6428b by the Vitest Coverage Report Action

Copy link
Contributor

@enesozturk enesozturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

@tomiir tomiir merged commit ac76c05 into main Jul 3, 2025
40 checks passed
@tomiir tomiir deleted the feat/ownable-validator branch July 3, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants