fix(gitlab): smart truncate comments

[amishk783]

Changes

Context

• closes platform(gitlab): comment length not truncated #30551

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[CLAassistant]

All committers have signed the CLA.

[RahulGautamSingh]

Trunacate the body content before we compute commentNeedsUpdating. Else, we will compare full body content with comment body we fetch from api. And, the fetched body will be truncated whereas full body (from fn param) won't.

This will cause the comment to be updated each time.

[viceice]

See conversation

[amishk783]

Hi Rahul, Thanks for the guidance. I’ve moved smartTruncate(body, maxBodyLength()) before the commentNeedsUpdating check in the if-else case and will push the changes shortly.

[amishk783]

Thanks @amishk783 for the fix, anything blocking this being merged in?

required changes are not pushed. also CI falls, so merge isn't an option.

Hey, sorry for the delay. it completely slipped my mind. I've pushed the changes and addressed the feedback. Now truncating the body before checking commentNeedsUpdating

[henry-fn]

Thanks @amishk783 for the fix, anything blocking this being merged in?

required changes are not pushed. also CI falls, so merge isn't an option.

Hey, sorry for the delay. it completely slipped my mind. I've pushed the changes and addressed the feedback. Now truncating the body before checking commentNeedsUpdating

Just in case you missed it, I think there is still one linting test failing https://github.com/renovatebot/renovate/actions/runs/10960183807/job/30434310107?pr=30580

[henry-fn]

@amishk783 poke on formatting here?

[henry-fn]

Anything blocking merging here?

[rarkins]

@viceice please review