platform(gitlab): comment length not truncated

[RahulGautamSingh]

Discussed in #30508

^{Originally posted by henry-fn August 1, 2024}

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab

Please tell us more about your question or problem

Essentially #7775 has come back after some refactors. I think that we need a call to smartTruncate around here

renovate/lib/modules/platform/gitlab/index.ts

Line 1405 in ad7b3ce

}

So you could add a line like body = smartTruncate(body, maxBodyLength());

smartTruncate is already called in ensureIssue but not in ensureComment. I think this was just an oversight but it does cause renovate to sometimes crash for us in mysterious ways to our internal users until we inspect the underlying renovate logs.

Logs (if relevant)

Logs

"message": "Response code 400 (Bad Request)",
             "stack": "HTTPError: Response code 400 (Bad Request)\n    at Request.<anonymous> (/usr/lib/node_modules/renovate/node_modules/got/dist/source/as-promise/index.js:118:42)\n    at processTicksAndRejections (node:internal/process/task_queues:95:5)",
             "options": {
               "headers": {
                 "user-agent": "RenovateBot/37.440.7 (https://github.com/renovatebot/renovate)",
                 "accept": "application/json",
                 "authorization": "***********",
                 "content-type": "application/json",
                 "content-length": "1001123",
                 "accept-encoding": "gzip, deflate, br"
               },
               "url": "REDACTED/merge_requests/3149/notes",
               "hostType": "gitlab",
               "username": "",
               "password": "",
               "method": "POST",
               "http2": false
             },
             "response": {
               "statusCode": 400,
               "statusMessage": "Bad Request",
               "body": {
                 "message": "400 Bad request - Note {:note=>[\"is too long (maximum is 1000000 characters)\"]}"
               },
               "headers": {...

[amishk783]

hey rahul, I would like to work on this issue.