Skip to content

Conversation

@machour
Copy link
Contributor

@machour machour commented Jul 17, 2022

Follow up to #3776

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2022

⚠️ No Changeset found

Latest commit: 3b18c5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title chore(uploads): Update jsdoc for filter chore(remix-node): update jsdoc for FileUploadHandlerOptions' filter Jul 17, 2022
Comment on lines 61 to +63
* @param filename
* @param mimetype
* @param encoding
* @param contentType
* @param name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to fix the JSDOC

   * @param FileUploadHandlerFilterArgs <desc>
   * @param FileUploadHandlerFilterArgs.filename <desc>
   * @param FileUploadHandlerFilterArgs.mimetype <desc>
   * @param FileUploadHandlerFilterArgs.encoding <desc>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean @3imed-jaberi, the accurate properties are contentType and name.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3imed-jaberi oh yes I see. I'm sticking to the team's choice here.
Feel free to open a new discussion to propose a change to jsdoc all over the repo.

@machour machour force-pushed the chore/update-filter-args-for-upload branch from 8783e9d to 3b18c5e Compare January 24, 2023 11:54
@chaance chaance merged commit 57004e3 into remix-run:dev Jan 24, 2023
@machour machour deleted the chore/update-filter-args-for-upload branch January 24, 2023 13:22
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-c9ff7ef-20230125 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants