-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore(remix-node): update jsdoc for FileUploadHandlerOptions' filter
#3777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(remix-node): update jsdoc for FileUploadHandlerOptions' filter
#3777
Conversation
|
FileUploadHandlerOptions' filter
| * @param filename | ||
| * @param mimetype | ||
| * @param encoding | ||
| * @param contentType | ||
| * @param name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to fix the JSDOC
* @param FileUploadHandlerFilterArgs <desc>
* @param FileUploadHandlerFilterArgs.filename <desc>
* @param FileUploadHandlerFilterArgs.mimetype <desc>
* @param FileUploadHandlerFilterArgs.encoding <desc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean @3imed-jaberi, the accurate properties are contentType and name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@3imed-jaberi oh yes I see. I'm sticking to the team's choice here.
Feel free to open a new discussion to propose a change to jsdoc all over the repo.
8783e9d to
3b18c5e
Compare
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Follow up to #3776