Skip to content

docs(api/remix): update unstable_createFileUploadHandler's filter signature #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

docs(api/remix): update unstable_createFileUploadHandler's filter signature #3776

merged 1 commit into from
Jul 17, 2022

Conversation

@machour
Copy link
Contributor

@machour machour commented Jul 17, 2022 •
edited
Loading

Updated unstable_createFileUploadHandler callbacks signature according to the changes that happened in #2736

Closes #3756

@machour machour added the docs label Jul 17, 2022
@machour machour requested a review from jacob-ebey July 17, 2022 01:04
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2022

⚠️ No Changeset found

Latest commit: f342e1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kentcdodds
kentcdodds approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 109da88 into remix-run:main Jul 17, 2022
@machour machour deleted the docs/3756-update-upload-handler-args branch July 17, 2022 08:11
@machour machour mentioned this pull request Jul 17, 2022
Merged
@MichaelDeBoey MichaelDeBoey changed the title docs(uploads): Update unstable_createFileUploadHandler callbacks signature docs(api/remix): update unstable_createFileUploadHandler's filter signature Jul 17, 2022
dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
@machour @dvargas92495
docs(file-uploads): Update unstable_createFileUploadHandler callbacks…
1032789 
… signatures (remix-run#3776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@jacob-ebey jacob-ebey Awaiting requested review from jacob-ebey

Assignees

@kentcdodds kentcdodds

Labels

CLA Signed docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect documentation for filter on uploadHandler

2 participants

@machour @kentcdodds