Move rollup configs to individual packages#3376
Conversation
f8cee27 to
2a14bf1
Compare
1a9ec85 to
716dc90
Compare
716dc90 to
357232c
Compare
c4490ae to
7a629b0
Compare
…into brophdawg11/rollup-prep
The main value add for the abstractions were the So yea, this makes sense! |
|
Hey this is passing windows CI tests now?? 🥳 Any idea why? |
|
|
@brophdawg11 Should be good for another pass here.
My rule of thumb is to never ask this question and just be thankful (meaning, I have no idea why 😅) |
|
Looking good! I ran a fresh build on dev and this branch and found a few small magic exports deltas - but unsure if I know which is correct:
Otherwise the builds looked identical minus two small |
This should be like we have on |
|
@brophdawg11 Addressed both of those issues. Confirmed that magic exports match what's on dev, and the webpack comment should be included here 👍 |
|
🤖 Hello there, We just published version Thanks! |
I am trying to build individual packages but it's not working: |
This PR splits the root
rollup.config.jsfile out to individualpackages/{name}/rollup.config.jsfiles, and adjusts the rootrollup.config.jsfile to read allpackages/{name}/rollup.config.jsfiles to auto-generat the root config. This is similar in nature to thejestapproach this repo is using.This has two primary benefits:
react-router(once we merge theremixingbranch) and aligningreact-routerto use the same exact approach androllup.utils.jsfile. This means that we do not have to merge the rootrollup.config.jsfile fromremixintoreact-routerat all. When we migrate theremixpackages/*folders, they will bring along the package-specificrollup.config.jsfiles, and thereact-routerrootrollup.config.jsfile will just automatically pick up on them 😄npx rollup -cdirectly from within apackages/{name}directory if we don't need to build everything. This also "just works" with things likeLOCAL_BUILD_DIRECTORYandrollup -w- both from the root and from individual packagesTo test, I ran fresh builds on both
devand this branch and ensureddiff -rq build-dev/ build-branch/didn't report any differences.