ci: Update rollup setup#8953
Merged
Merged
Conversation
brophdawg11
commented
Jun 8, 2022
brophdawg11
commented
Jun 8, 2022
chaance
reviewed
Jun 8, 2022
brophdawg11
commented
Jun 9, 2022
brophdawg11
commented
Jun 9, 2022
chaance
reviewed
Jun 9, 2022
chaance
reviewed
Jun 9, 2022
chaance
reviewed
Jun 9, 2022
chaance
approved these changes
Jun 9, 2022
brophdawg11
commented
Jun 9, 2022
| }, | ||
| "scripts": { | ||
| "build": "rollup -c && tsc -b", | ||
| "build": "rollup -c", |
Contributor
Author
There was a problem hiding this comment.
.d.ts files are generated by @rollup/plugin-typescript now
brophdawg11
commented
Jun 9, 2022
| "main": "./dist/main.js", | ||
| "unpkg": "./dist/umd/react-router.production.min.js", | ||
| "module": "./dist/index.js", | ||
| "types": "./dist/index.d.ts", |
Contributor
Author
There was a problem hiding this comment.
Just as a note - Chance's changesets PR will be adding the proper files arrays to package.json - left out of here to avoid conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as remix-run/remix#3376 for this repo.
rollupto the latest version (4f62c1e)rollup.config.jsfiles out into the individualpackages/*directories (c04c2d8)rollup.config.jswhich automatically loads allpackages/*/rollup.config.jsfiles and does a full buildtsc -band moves to@rollup/plugin-typescriptto generate.d.tsfilesThis allows us to run
npx rollup -c [--watch]from either the root or the individual package directories.This also moves the build output to
packages/*/dist/directories and does a few things that stemmed from that:package.jsonmain/module/typesreferencesmoduleNameMapperstojestconfigs to avoid running unit tests ondist/folder contents