Fix long standing jump bug & movement lag based on FPS #755

ShadowsAdi · 2022-04-29T21:27:26Z

// Legacy movement. The new one fixes FPS based jump and movement.
// 0 - Legacy behavior
// 1 - New behavior
//
// Default value: "0"
sv_legacy_movement 0

~~IT SHOULD BE TESTED MORE, I TESTED IT ONLY IN SINGLE PLAYER~~

ValveSoftware/halflife#81
ValveSoftware/halflife#682

https://github.com/pmrowla/hl2sdk-csgo/blob/master/game/shared/gamemovement.cpp#L1211

I'm sorry for the build.yml changes, just tested a few ways of achieving this.

ValveSoftware/halflife#81 ValveSoftware/halflife#682 https://github.com/pmrowla/hl2sdk-csgo/blob/master/game/shared/gamemovement.cpp#L1211

…_teleport (rehlds#747)" This reverts commit 21dab90.

RauliTop · 2022-05-09T16:49:41Z

@ShadowsAdi have you already test this on multiplayer? Working well?

This will change the behaviour of gameplay, probably a cvar to disable should be great.

ShadowsAdi · 2022-05-09T17:00:28Z

have you already test this on multiplayer? Working well?

Yes, it's working just fine on multiplayer too, on a 32/32 server.

This will change the behaviour of gameplay, probably a cvar to disable should be great.

I don't think it requires a cvar because it fixes something that it's kinda broken. That slow was just annoying while using lower or higher FPS than 100.

RauliTop · 2022-05-10T08:52:11Z

have you already test this on multiplayer? Working well?

Yes, it's working just fine on multiplayer too, on a 32/32 server.

This will change the behaviour of gameplay, probably a cvar to disable should be great.

I don't think it requires a cvar because it fixes something that it's kinda broken. That slow was just annoying while using lower or higher FPS than 100.

Physics are dependant from FPS, yes, it's a bug.

But some mods use this logic, for example KZ or HNS. If you have less fps, like 20, your slowdown jump is less than having 80-100 fps.

Consider adding the cvar, please. It's not for me, I'm talking about other players

ShadowsAdi · 2022-05-10T12:31:56Z

But some mods use this logic, for example KZ or HNS. If you have less fps, like 20, your slowdown jump is less than having 80-100 fps.

This fix should help especially these mods because you can't gain more speed while bhopping ( as before ) it just fix the movement slow after jumping.

Consider adding the cvar, please. It's not for me, I'm talking about other players

I still don't see the relevance of adding a cvar just to fix something that was broken. This implementation is still under REGAMEDLL_FIXES macro so it's behaviour can be always changed as it was before.

fred0r · 2022-05-20T19:49:24Z

been using this for about ~1,5 weeks now and it seem to work correct.
a cvar would indeed be nice to make it easier to check the changed behavior, since there would be no need to stop the server and replace the cs.so every time.

Garey27 · 2022-05-21T20:53:38Z

There will be same behaviour no matter frametime * 1000 or msec.
https://github.com/s1lentq/ReGameDLL_CS/blob/b9cccc691bdabbf9cb573be8ee5e39c9a4f70c4a/regamedll/pm_shared/pm_shared.cpp#L2841
So tell me what a difference between this logic:

reduce timers by cmd.msec
or
reduce timer by frametime which are calulcated also by cmd.msec ? This PR is useless.

Garey27 · 2022-05-21T20:57:10Z

Also if u look in csgo CGameMovement::ReduceTimers there global frametime not players one. Which is wrong for Half-Life/CS because we simulate shared movement code where timers reduces by player fps! not server one.

ShadowsAdi · 2022-05-21T21:19:06Z

https://github.com/s1lentq/ReGameDLL_CS/blob/b9cccc691bdabbf9cb573be8ee5e39c9a4f70c4a/regamedll/pm_shared/pm_shared.cpp#L2841

I know, but it seems working correctly as it is now.

There will be same behaviour no matter frametime * 1000 or msec.

This PR is useless.

Test it out, compare the results by yourself and reply to this thread again.

Garey27 · 2022-05-21T22:03:37Z

Ok i was tested and its absolutely same behaviour as without fix. Notice the slowdown with 500 fps and no slowdown with 20 fps. (jump crouched > unduck when touch ground and hold +forward).
There no difference.
https://user-images.githubusercontent.com/4866813/169670327-1272b3f0-8c08-4bdd-a645-4b13862741a4.mp4

.

ShadowsAdi · 2022-05-22T07:51:31Z

Ok i was tested and its absolutely same behaviour as without fix. Notice the slowdown with 500 fps and no slowdown with 20 fps. (jump crouched > unduck when touch ground and hold +forward). There no difference. https://user-images.githubusercontent.com/4866813/169670327-1272b3f0-8c08-4bdd-a645-4b13862741a4.mp4

.

After some debuggings, I found out that the windows version of the ReGameDLL is not based on any of the additional preprocessor defs. It is just a pure version without any additional fixes.

In linux, it seems to build it using the preprocessor definitions.

https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/msvc/ReGameDLL.vcxproj#L959

Also, check this out: https://github.com/ShadowsAdi/ReGameDLL_CS/runs/6542189855?check_suite_focus=true
It can't get the sv_legacy_movement ( a cvar created for this PR ) pointer address because it is under REGAMEDLL_FIXES
https://github.com/s1lentq/ReGameDLL_CS/blob/master/regamedll/dlls/game.h#L135

… trigger_teleport (rehlds#747)"" This reverts commit 0bc3351.

fred0r · 2022-05-23T04:04:31Z

pls approve workflow

lespaul64 · 2022-05-31T07:17:03Z

Finally someone willing to fix this issue. This is a game bug, fix is a must.

Yes i noticed this bug too especially when playing fps more than 100~120. The only way to get fast jump penalty is to use fps_max 60, 60fps to play fps game haha this is terrible. With 60fps i can't even climb a pyramid, but with 256fps i can easily climb but this jump penalty bug is annoying. In certain mode for example ZE, we all know this mode is base on speed, but with so many obstacle that need to jump and duck i lost because of jump penalty.

I play csgo too, but csgo doesn't have this bug, i can play more than 300fps.

Where is the compiled binary for this latest PR? can't even find it. I wanna test too.

Edited
Wait do not approve yet, I've compiled the source and tested, this PR is changing game behavior, it doesn't have slowdown at all whether with 60 or 200fps. This is similar to use fuser2 = 0.0 in PlayerPreThink. A bit hard to jump on small platform because it's too smooth you will easily fall down.

ShadowsAdi · 2022-05-31T09:15:02Z

Until this workflow is approved, you can download the compiled binaries for this PR here: https://github.com/ShadowsAdi/ReGameDLL_CS/actions/runs/2413788290 În mar., 31 mai 2022 la 10:17, lespaul64 ***@***.***> a scris:

…

Finally someone willing to fix this issue. This is a game bug, fix is a must. Yes i noticed this bug too especially when playing fps more than 100~120. The only way to get fast jump penalty is to use fps_max 60, 60fps to play fps game haha this is terrible. With 60fps i can't even climb a pyramid, but with 256fps i can easily climb but this jump penalty bug is annoying. In certain mode for example ZE, we all know this mode is base on speed, but with so many obstacle that need to jump and duck i lost because of jump penalty. I play csgo too, but csgo doesn't have this bug, i can play more than 300fps. Where is the compiled binary for this latest PR? can't even find it. I wanna test too. — Reply to this email directly, view it on GitHub <#755 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM6WH6T3M2KUBCNV2XPRZNTVMW4HXANCNFSM5UXIOFNA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

ShadowsAdi · 2022-05-31T20:30:34Z

@lespaul64 could you test it after changes and review it?

RauliTop · 2022-05-31T22:34:13Z

Please @ShadowsAdi, explain that new magical numbers

lespaul64 · 2022-06-01T04:57:28Z

@lespaul64 could you test it after changes and review it?

Ok the new patch is acceptable for me, can feel the different. Playing with 256fps now feel a bit similar to 60fps jump penalty behavior. Maybe need so tweaks on the magic numbers & calculations. BTW where did you get that numbers?

ShadowsAdi · 2022-06-01T12:47:51Z

Please @ShadowsAdi, explain that new magical numbers

Ok the new patch is acceptable for me, can feel the different. Playing with 256fps now feel a bit similar to 60fps jump penalty behavior. Maybe need so tweaks on the magic numbers & calculations. BTW where did you get that numbers?

I tested some values locally, on a windows build running at 1000 FPS + client running at 700-900 FPS.
These values seemed to fix the issue, I will do some more math to gain better results.

https://github.com/s1lentq/ReGameDLL_CS/pull/755/files#diff-2aeae34eebf30e19694d07e23caecbe3a34e1d0fdc4cec2fd75fd14b34a1c10bR2781

From my tests, cmd.msec values will be greater than 10 while client is running at < 150 FPS and will be lower than 10 from 150 FPS above.

SmileYzn · 2022-06-01T16:30:12Z

Sorry for noob question, but why not put a cvar to enable/disable this FPS fix with cvars to control these values if fix is enabled on server?

Soo someone can approve workflow to run the server testing values instead of a lot of builds.

ShadowsAdi · 2022-06-01T18:02:13Z

Sorry for noob question, but why not put a cvar to enable/disable this FPS fix with cvars to control these values if fix is enabled on server?

Because that value should not be modified, same as other important values in gamedll.

dist/game.cfg

regamedll/dlls/game.cpp

SmileYzn · 2022-06-01T19:00:53Z

Sorry for noob question, but why not put a cvar to enable/disable this FPS fix with cvars to control these values if fix is enabled on server?

Because that value should not be modified, same as other important values in gamedll.

In your tests you changed values, OK

In my tests i can't change values? why?

I did not understand, ReHLDS ecosystem has a lot of these 'magical' values by cvars. What is the problem?

I really understand that variables and values are really important, but the reason to give the cvars for change according cvars that do not make sense to me.

Also other thing, is really a BUG because the original HLDS do not have values fixed and other small changes in code. Bug let's threat this as feature than a bug is not a better way in this case?

SmileYzn · 2022-06-01T19:16:07Z

I forgot to mention, in first release of this fps fix, the step sounds is a bit accelerated in remote server with pingboost 3, sys_ticrate 1000 and rate 100000 and updaterate & cmdrate 102.

First build from here: https://github.com/s1lentq/ReGameDLL_CS/actions/runs/2247829843

I did not know if fix is not complete in first build.

ShadowsAdi · 2022-06-01T19:18:27Z

In your tests you changed values, OK

In my tests i can't change values? why?

I did not understand, ReHLDS ecosystem has a lot of these 'magical' values by cvars. What is the problem?

Right now, this is reGameDLL, it hasn't "magical" values by cvars when you shoot with a weapon, or when you reload one. They are hardcoded values for a reason.

Also other thing, is really a BUG because the original HLDS do not have values fixed and other small changes in code. Bug let's threat this as feature than a bug is not a better way in this case?

If more people complain for that, it's not a feature.

ShadowsAdi · 2022-06-01T19:20:05Z

I forgot to mention, in first release of this fps fix, the step sounds is a bit accelerated in remote server with pingboost 3, sys_ticrate 1000 and rate 100000 and updaterate & cmdrate 102.

Fixed, thank you for report!

And added suggestions from @wopox1337

@SmileYzn

Thanks to @SmileYzn

SmileYzn · 2022-06-10T12:30:29Z

Sorry for bump, but i want to test these changes.
Some news?

Thanks 👍

SergeyShorokhov · 2022-06-10T12:38:29Z

@SmileYzn You can test with artifact releases 🧐

SmileYzn · 2022-06-10T12:56:00Z

@SmileYzn You can test with artifact releases monocle_face

Yes but it has requested changes, anyway i think will not change anything with

ShadowsAdi · 2022-06-10T14:49:35Z

@SmileYzn You can test with artifact releases monocle_face

Yes but it has requested changes, anyway i think will not change anything with

It shows that because it hasn't been reviewed yet. I added the suggestions proposed by @wopox1337.

fred0r · 2022-10-11T03:42:02Z

5.21.0.573-dev on linux 
-pingboost 3
-sys_ticrate 1016
schedtool with SCHED_RR

players complain that they can jump further/higher than before - clients were running at 100 fps (dflt).

SmilexGamer · 2023-12-27T09:22:38Z

Will this request be pushed soon?

ShadowsAdi added 4 commits April 29, 2022 02:28

Update build.yml

0a6e454

Update build.yml

99d4ecf

Fix long standing jump bug & movement lag based on FPS

4ae0ca4

ValveSoftware/halflife#81 ValveSoftware/halflife#682 https://github.com/pmrowla/hl2sdk-csgo/blob/master/game/shared/gamemovement.cpp#L1211

Revert "Added spawnflags for keep player angles & velocity in trigger…

0bc3351

…_teleport (rehlds#747)" This reverts commit 21dab90.

ShadowsAdi added 3 commits May 22, 2022 13:01

Added sv_legacy_movement cvar & fixed some math

408d783

Revert "Revert "Added spawnflags for keep player angles & velocity in…

744b579

… trigger_teleport (rehlds#747)"" This reverts commit 0bc3351.

Update pm_shared.cpp

c0c5fc5

Fixed windows compilation

57b3e9b

Changed calculation method for cmd.msec

91c446f

SergeyShorokhov requested changes Jun 1, 2022

View reviewed changes

dist/game.cfg Outdated Show resolved Hide resolved

regamedll/dlls/game.cpp Outdated Show resolved Hide resolved

ShadowsAdi added 2 commits June 1, 2022 22:20

Fixed calculation for cmd.msec greater than 10.0

ae98a6b

And added suggestions from @wopox1337

Fixed step sound glitch

675ffe2

Thanks to @SmileYzn

ShadowsAdi closed this Jun 1, 2022

ShadowsAdi reopened this Jun 1, 2022

ShadowsAdi requested a review from SergeyShorokhov June 1, 2022 19:26

Merge branch 'master' into pr/ShadowsAdi/755

16e5c44

SergeyShorokhov assigned ShadowsAdi Oct 8, 2022

SergeyShorokhov added Type: Bug in original gamedll Priority: Low Status: Completed labels Oct 8, 2022

Merge branch 'master' into fix-fps-based-movement

7227d4f

This comment was marked as duplicate.

Sign in to view

s1lentq force-pushed the master branch from d3c8ba8 to 4d90a5f Compare February 1, 2024 11:48

s1lentq closed this May 8, 2024

Garey27 mentioned this pull request Aug 27, 2024

Add cvar for stamina restoration speed based on fps reference. #1005

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix long standing jump bug & movement lag based on FPS #755

Fix long standing jump bug & movement lag based on FPS #755

ShadowsAdi commented Apr 29, 2022 •

edited by SergeyShorokhov

Loading

RauliTop commented May 9, 2022 •

edited

Loading

ShadowsAdi commented May 9, 2022 •

edited

Loading

RauliTop commented May 10, 2022

ShadowsAdi commented May 10, 2022

fred0r commented May 20, 2022 •

edited

Loading

Garey27 commented May 21, 2022

Garey27 commented May 21, 2022

ShadowsAdi commented May 21, 2022

Garey27 commented May 21, 2022

ShadowsAdi commented May 22, 2022 •

edited

Loading

fred0r commented May 23, 2022

lespaul64 commented May 31, 2022 •

edited

Loading

ShadowsAdi commented May 31, 2022 via email

ShadowsAdi commented May 31, 2022

RauliTop commented May 31, 2022

lespaul64 commented Jun 1, 2022 •

edited

Loading

ShadowsAdi commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022 •

edited

Loading

SmileYzn commented Jun 10, 2022

SergeyShorokhov commented Jun 10, 2022

SmileYzn commented Jun 10, 2022

ShadowsAdi commented Jun 10, 2022

fred0r commented Oct 11, 2022 •

edited

Loading

This comment was marked as duplicate.

SmilexGamer commented Dec 27, 2023

Fix long standing jump bug & movement lag based on FPS #755

Fix long standing jump bug & movement lag based on FPS #755

Conversation

ShadowsAdi commented Apr 29, 2022 • edited by SergeyShorokhov Loading

RauliTop commented May 9, 2022 • edited Loading

ShadowsAdi commented May 9, 2022 • edited Loading

RauliTop commented May 10, 2022

ShadowsAdi commented May 10, 2022

fred0r commented May 20, 2022 • edited Loading

Garey27 commented May 21, 2022

Garey27 commented May 21, 2022

ShadowsAdi commented May 21, 2022

Garey27 commented May 21, 2022

ShadowsAdi commented May 22, 2022 • edited Loading

fred0r commented May 23, 2022

lespaul64 commented May 31, 2022 • edited Loading

ShadowsAdi commented May 31, 2022 via email

ShadowsAdi commented May 31, 2022

RauliTop commented May 31, 2022

lespaul64 commented Jun 1, 2022 • edited Loading

ShadowsAdi commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

SmileYzn commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022

ShadowsAdi commented Jun 1, 2022 • edited Loading

SmileYzn commented Jun 10, 2022

SergeyShorokhov commented Jun 10, 2022

SmileYzn commented Jun 10, 2022

ShadowsAdi commented Jun 10, 2022

fred0r commented Oct 11, 2022 • edited Loading

This comment was marked as duplicate.

SmilexGamer commented Dec 27, 2023

ShadowsAdi commented Apr 29, 2022 •

edited by SergeyShorokhov

Loading

RauliTop commented May 9, 2022 •

edited

Loading

ShadowsAdi commented May 9, 2022 •

edited

Loading

fred0r commented May 20, 2022 •

edited

Loading

ShadowsAdi commented May 22, 2022 •

edited

Loading

lespaul64 commented May 31, 2022 •

edited

Loading

lespaul64 commented Jun 1, 2022 •

edited

Loading

ShadowsAdi commented Jun 1, 2022 •

edited

Loading

fred0r commented Oct 11, 2022 •

edited

Loading