Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/ecocredit): buy/sell query server #645

Merged
merged 12 commits into from
Dec 1, 2021
Merged

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Nov 17, 2021

Description

Closes: #643

Add QueryServer implementation for marketplace query API.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #645 (47bc1fa) into master (f706392) will increase coverage by 1.34%.
The diff coverage is 91.22%.

❗ Current head 47bc1fa differs from pull request most recent head c1ba100. Consider uploading reports for the commit c1ba100 to get more accurate results

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   72.11%   73.45%   +1.34%     
==========================================
  Files         107      107              
  Lines       15212    15876     +664     
==========================================
+ Hits        10970    11662     +692     
+ Misses       3481     3401      -80     
- Partials      761      813      +52     
Flag Coverage Δ
experimental-codecov 73.58% <91.22%> (+1.34%) ⬆️
stable-codecov 65.80% <91.22%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

true,
"not found",
},
// TODO: filtered buy orders required #623
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we are not storing direct buy orders and we have not implemented indirect buy orders (#623), so creating a buy order with Buy does not store a buy order and we have no buy orders to query.

@ryanchristo ryanchristo marked this pull request as ready for review November 18, 2021 01:08
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Nov 18, 2021
@clevinson clevinson self-assigned this Nov 18, 2021
@ryanchristo ryanchristo changed the title feat: buy/sell query server feat(x/ecocredit): buy/sell query server Nov 18, 2021
@likhita-809
Copy link
Contributor

can you fix these failing tests @ryanchristo ?

@ryanchristo
Copy link
Member Author

can you fix these failing tests @ryanchristo ?

Just needed to run go mod tidy after merging master. Thanks! Ready for review.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pre-approving.

Can u also add gRPC REST tests?

@ryanchristo
Copy link
Member Author

Can u also add gRPC REST tests?

Tests added but partially commented out because they are dependent on the creation of buy/sell orders and allowed ask denoms via CLI integration tests and we have not yet implemented CLI commands for marketplace functionality. #615

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ryanchristo ryanchristo merged commit aebf1ea into master Dec 1, 2021
@ryanchristo ryanchristo deleted the ryan/643-query-server branch December 1, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement QueryServer for marketplace functionality
4 participants