-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(x/ecocredit): buy/sell query server #645
Conversation
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 72.11% 73.45% +1.34%
==========================================
Files 107 107
Lines 15212 15876 +664
==========================================
+ Hits 10970 11662 +692
+ Misses 3481 3401 -80
- Partials 761 813 +52
Flags with carried forward coverage won't be shown. Click here to find out more. |
true, | ||
"not found", | ||
}, | ||
// TODO: filtered buy orders required #623 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are not storing direct buy orders and we have not implemented indirect buy orders (#623), so creating a buy order with Buy
does not store a buy order and we have no buy orders to query.
can you fix these failing tests @ryanchristo ? |
Just needed to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pre-approving.
Can u also add gRPC REST tests?
Tests added but partially commented out because they are dependent on the creation of buy/sell orders and allowed ask denoms via CLI integration tests and we have not yet implemented CLI commands for marketplace functionality. #615 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Closes: #643
Add QueryServer implementation for marketplace query API.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change