Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtered buy orders #623

Open
4 tasks
Tracked by #1311
ryanchristo opened this issue Nov 5, 2021 · 2 comments
Open
4 tasks
Tracked by #1311

Implement filtered buy orders #623

ryanchristo opened this issue Nov 5, 2021 · 2 comments
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Status: Proposed

Comments

@ryanchristo
Copy link
Member

Summary

Currently MsgBuy implements a buy order selection with the option to create a direct buy order using sell_order_id. Once we have filters defined for baskets, we can enable filtered buy orders and implement buy order processing.

    // Selection defines a buy order selection.
    message Selection {

      // sum defines the type of selection.
      oneof sum {
        // sell_order_id is the sell order ID against which the buyer is trying to buy.
        // When sell_order_id is set, this is known as a direct buy order because it
        // is placed directly against a specific sell order.
        uint64 sell_order_id = 1;

        // TODO: once we have filters defined for baskets, we can enable filtered
        // buy orders which will involve full double-sided batch order matching
        //
        // filter selects credits to buy based upon the specified filter criteria.
        // Filter filter = 2;
      }
    }

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ryanchristo ryanchristo added the Scope: x/ecocredit Issues that update the x/ecocredit module label Nov 5, 2021
@ryanchristo
Copy link
Member Author

We will need to take second look at the message fields for the BuyOrderCreated event. See #613 (comment).

@clevinson
Copy link
Member

Should this be included in the next upgrade? It seems like the feature is well enough specified where we could get support for non-direct buy orders in this same release.

Thoughts @aaronc @dtkong ?

@ryanchristo ryanchristo removed this from the v4.0 - Llangorse Upgrade milestone Mar 6, 2022
@ryanchristo ryanchristo added this to the v5.0 - Titicaca Upgrade milestone Apr 2, 2022
@ryanchristo ryanchristo mentioned this issue Apr 2, 2022
34 tasks
@ryanchristo ryanchristo changed the title Implement buy order processing for filtered buy orders Implement filtered buy orders Apr 5, 2022
@ryanchristo ryanchristo removed this from the v5.0 - Titicaca Upgrade milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: x/ecocredit Issues that update the x/ecocredit module Status: Proposed
Projects
None yet
Development

No branches or pull requests

2 participants