chore: update go module versions #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1646 +/- ##
==========================================
- Coverage 78.25% 73.03% -5.22%
==========================================
Files 266 228 -38
Lines 19772 13332 -6440
==========================================
- Hits 15472 9737 -5735
+ Misses 3419 2884 -535
+ Partials 881 711 -170
|
ryanchristo
commented
Nov 29, 2022
clevinson
approved these changes
Nov 30, 2022
| @@ -126,4 +126,6 @@ require ( | |||
|
|
|||
| replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1 | |||
|
|
|||
| replace github.com/regen-network/regen-ledger/types => ../../types | |||
| replace github.com/regen-network/regen-ledger/api/v2 => ../../api | |||
There was a problem hiding this comment.
Suggested change
| replace github.com/regen-network/regen-ledger/api/v2 => ../../api |
I don't see api/v2 anywhere in this g.mod, so I don't think we need the replace directive here.
There was a problem hiding this comment.
types imports api so we get the following if not included:
go: github.com/regen-network/regen-ledger/api/v2@v2.0.0: invalid version: unknown revision api/v2.0.0
because it can't find api/v2 (it doesn't exist yet)
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 18fbac7)
ryanchristo
added a commit
that referenced
this pull request
Nov 30, 2022
aaronc
reviewed
Dec 12, 2023
| @@ -1,4 +1,4 @@ | |||
| module github.com/regen-network/regen-ledger/api | |||
| module github.com/regen-network/regen-ledger/api/v2 | |||
There was a problem hiding this comment.
Why was this done? This seems like a spurious go module major version bump. Were there actually breaking changes? I thought we weren't releasing breaking proto changes to production. With proper buf breaking checks, the api go.mod should never have been bumped past v1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates app, api, types, data, and ecocredit go module versions to the latest major versions that will be tagged as part of the v5.0 release (app => v5, api => v2, types => v2, data => v2, ecocredit => v3).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change