Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(canary): add back api server for yarn rw dev #8336

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 16, 2023

Note

This is only in canary and doesn't require releasing a patch.

If you upgrade to 6.0.0-canary.168 canary and run yarn rw dev you'll get:

api | node:internal/modules/cjs/loader:1078
api |   throw err;
api |   ^
api | 
api | Error: Cannot find module '@redwoodjs/api-server/package.json'
api | Require stack:
api | - /Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/core/dist/bins/rw-log-formatter.js
api |     at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
api |     at Function.resolve (node:internal/modules/cjs/helpers:116:19)
api |     at Object.<anonymous> (/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/core/dist/bins/rw-log-formatter.js:5:65)
api |     at Module._compile (node:internal/modules/cjs/loader:1254:14)
api |     at Module._extensions..js (node:internal/modules/cjs/loader:1308:10)
api |     at Module.load (node:internal/modules/cjs/loader:1117:32)
api |     at Module._load (node:internal/modules/cjs/loader:958:12)
api |     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
api |     at node:internal/main/run_main_module:23:47 {
api |   code: 'MODULE_NOT_FOUND',
api |   requireStack: [
api |     '/Users/dom/prjcts/redwood/redwood-app/node_modules/@redwoodjs/core/dist/bins/rw-log-formatter.js'
api |   ]
api | }

This is because I removed the api-server package from the CLI's dependencies. I replaced it with @redwoodjs/fastify in #8119 but I missed the fact that there's this bin here the CLI also needs that api-server exports. To fix canary, this PR adds api-server back.

The reason this wasn't caught in CI is that yarn rwfw adds all redwood packages to a project, so it's hard to detect if a required one is missing.

@jtoar jtoar added the release:fix This PR is a fix label May 16, 2023
@jtoar jtoar enabled auto-merge (squash) May 16, 2023 04:44
@jtoar jtoar disabled auto-merge May 16, 2023 04:44
@jtoar jtoar merged commit 61d4449 into main May 16, 2023
@jtoar jtoar deleted the ds-cli/fix-yarn-rw-dev branch May 16, 2023 04:44
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 16, 2023
dac09 added a commit to dac09/redwood that referenced this pull request May 17, 2023
…te-default

* 'main' of github.com:redwoodjs/redwood: (30 commits)
  fix(deps): update dependency @vscode/ripgrep to v1.15.3 (redwoodjs#8341)
  fix(deps): update typescript-eslint monorepo to v5.59.6 (redwoodjs#8335)
  chore(deps): update dependency vite to v4.3.7 (redwoodjs#8340)
  fix(deps): update dependency qs to v6.11.2 (redwoodjs#8331)
  fix(deps): update dependency @tremor/react to v2.6.2 (redwoodjs#8337)
  chore(deps): update dependency vite to v4.3.6 (redwoodjs#8328)
  chore(deps): update dependency glob to v10.2.4 (redwoodjs#8326)
  fix: add back api server for yarn rw dev (redwoodjs#8336)
  chore(deps): update dependency @faker-js/faker to v8.0.1 (redwoodjs#8330)
  Disable plugin by default (redwoodjs#8334)
  fix(deps): update docusaurus monorepo to v2.4.1 (redwoodjs#8329)
  fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8321)
  chore(deps): update dependency @supabase/supabase-js to v2.22.0 (redwoodjs#8323)
  fix(deps): update dependency @tremor/react to v2.6.1 (redwoodjs#8320)
  fix(deps): update dependency listr2 to v6.5.0 (redwoodjs#8317)
  fix(deps): update dependency semver to v7.5.1 (redwoodjs#8307)
  fix(deps): update dependency @tremor/react to v2.5.0 (redwoodjs#8306)
  chore(deps): update dependency @testing-library/dom to v9.3.0 (redwoodjs#8303)
  chore(deps): update dependency esbuild to v0.17.19 (redwoodjs#8312)
  chore(deps): update dependency dependency-cruiser to v12.12.2 (redwoodjs#8310)
  ...
jtoar added a commit that referenced this pull request May 17, 2023
@jtoar jtoar modified the milestones: next-release, v5.2.0 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant