-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql-server): Disable the redwood opentelemetry plugin by default #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
May 15, 2023
Comment on lines
+122
to
+125
} catch (_error) { | ||
// Swallow this error for the time being as we don't always have access to the | ||
// config toml depending on the deploy environment | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, I forgot about this one
jtoar
pushed a commit
that referenced
this pull request
May 15, 2023
jtoar
pushed a commit
that referenced
this pull request
May 15, 2023
dac09
added a commit
to dac09/redwood
that referenced
this pull request
May 17, 2023
…te-default * 'main' of github.com:redwoodjs/redwood: (30 commits) fix(deps): update dependency @vscode/ripgrep to v1.15.3 (redwoodjs#8341) fix(deps): update typescript-eslint monorepo to v5.59.6 (redwoodjs#8335) chore(deps): update dependency vite to v4.3.7 (redwoodjs#8340) fix(deps): update dependency qs to v6.11.2 (redwoodjs#8331) fix(deps): update dependency @tremor/react to v2.6.2 (redwoodjs#8337) chore(deps): update dependency vite to v4.3.6 (redwoodjs#8328) chore(deps): update dependency glob to v10.2.4 (redwoodjs#8326) fix: add back api server for yarn rw dev (redwoodjs#8336) chore(deps): update dependency @faker-js/faker to v8.0.1 (redwoodjs#8330) Disable plugin by default (redwoodjs#8334) fix(deps): update docusaurus monorepo to v2.4.1 (redwoodjs#8329) fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8321) chore(deps): update dependency @supabase/supabase-js to v2.22.0 (redwoodjs#8323) fix(deps): update dependency @tremor/react to v2.6.1 (redwoodjs#8320) fix(deps): update dependency listr2 to v6.5.0 (redwoodjs#8317) fix(deps): update dependency semver to v7.5.1 (redwoodjs#8307) fix(deps): update dependency @tremor/react to v2.5.0 (redwoodjs#8306) chore(deps): update dependency @testing-library/dom to v9.3.0 (redwoodjs#8303) chore(deps): update dependency esbuild to v0.17.19 (redwoodjs#8312) chore(deps): update dependency dependency-cruiser to v12.12.2 (redwoodjs#8310) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8332
Problem
When adding the
useRedwoodOpenTelemetry
yoga plugin I had unconditionally added it as a plugin to all projects. I had considered this as okay given it would not interfere with users who did not have opentelemetry setup. I had not however considered users who wanted to use opentelemetry but with their own implementation.Solution
Enable only when
experimental.opentelemetry.enabled
is set true in the toml config.