Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql-server): Disable the redwood opentelemetry plugin by default #8334

Merged
merged 2 commits into from
May 15, 2023

Conversation

Josh-Walker-GM
Copy link
Collaborator

Fixes #8332

Problem
When adding the useRedwoodOpenTelemetry yoga plugin I had unconditionally added it as a plugin to all projects. I had considered this as okay given it would not interfere with users who did not have opentelemetry setup. I had not however considered users who wanted to use opentelemetry but with their own implementation.

Solution
Enable only when experimental.opentelemetry.enabled is set true in the toml config.

@Josh-Walker-GM Josh-Walker-GM added the release:fix This PR is a fix label May 15, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar May 15, 2023 21:43
Comment on lines +122 to +125
} catch (_error) {
// Swallow this error for the time being as we don't always have access to the
// config toml depending on the deploy environment
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I forgot about this one

@jtoar jtoar added this to the next-release-patch milestone May 15, 2023
@jtoar jtoar merged commit 3082b77 into main May 15, 2023
@jtoar jtoar deleted the jgmw-graphql/otel-plugin-disabled-by-default branch May 15, 2023 22:07
jtoar pushed a commit that referenced this pull request May 15, 2023
@jtoar jtoar modified the milestones: next-release-patch, v5.1.5 May 15, 2023
jtoar pushed a commit that referenced this pull request May 15, 2023
dac09 added a commit to dac09/redwood that referenced this pull request May 17, 2023
…te-default

* 'main' of github.com:redwoodjs/redwood: (30 commits)
  fix(deps): update dependency @vscode/ripgrep to v1.15.3 (redwoodjs#8341)
  fix(deps): update typescript-eslint monorepo to v5.59.6 (redwoodjs#8335)
  chore(deps): update dependency vite to v4.3.7 (redwoodjs#8340)
  fix(deps): update dependency qs to v6.11.2 (redwoodjs#8331)
  fix(deps): update dependency @tremor/react to v2.6.2 (redwoodjs#8337)
  chore(deps): update dependency vite to v4.3.6 (redwoodjs#8328)
  chore(deps): update dependency glob to v10.2.4 (redwoodjs#8326)
  fix: add back api server for yarn rw dev (redwoodjs#8336)
  chore(deps): update dependency @faker-js/faker to v8.0.1 (redwoodjs#8330)
  Disable plugin by default (redwoodjs#8334)
  fix(deps): update docusaurus monorepo to v2.4.1 (redwoodjs#8329)
  fix(deps): update dependency react-toastify to v9.1.3 (redwoodjs#8321)
  chore(deps): update dependency @supabase/supabase-js to v2.22.0 (redwoodjs#8323)
  fix(deps): update dependency @tremor/react to v2.6.1 (redwoodjs#8320)
  fix(deps): update dependency listr2 to v6.5.0 (redwoodjs#8317)
  fix(deps): update dependency semver to v7.5.1 (redwoodjs#8307)
  fix(deps): update dependency @tremor/react to v2.5.0 (redwoodjs#8306)
  chore(deps): update dependency @testing-library/dom to v9.3.0 (redwoodjs#8303)
  chore(deps): update dependency esbuild to v0.17.19 (redwoodjs#8312)
  chore(deps): update dependency dependency-cruiser to v12.12.2 (redwoodjs#8310)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Experimental (?) useRedwoodOpenTelemetry is unconditionally enabled without opt-in as of Redwood 5.x
2 participants