chore(lint): enable 'typescript-eslint/no-unnecessary-type-assertion'

.eslintrc.js

@@ -204,7 +204,6 @@ module.exports = {
         '@typescript-eslint/require-await': 'off',
         '@typescript-eslint/prefer-nullish-coalescing': 'off',
         '@typescript-eslint/no-unsafe-member-access': 'off',
-        '@typescript-eslint/no-unnecessary-type-assertion': 'off',
         '@typescript-eslint/dot-notation': 'off',
         '@typescript-eslint/no-unsafe-argument': 'off',
         '@typescript-eslint/no-unsafe-return': 'off',

packages/api/src/cache/index.ts

@@ -191,7 +191,7 @@ export const createCache = (
 
     try {
       await Promise.race([
-        (result = client.del(cacheKey as string)),
+        (result = client.del(cacheKey)),
         wait(timeout).then(() => {
           throw new CacheTimeoutError()
         }),

packages/auth-providers/dbAuth/api/src/DbAuthHandler.ts

@@ -705,11 +705,9 @@ export class DbAuthHandler<
     }
 
     // check if password is valid using signup criteria
-    ;(this.options.signup as SignupFlowOptions).passwordValidation?.(
-      password as string,
-    )
+    ;(this.options.signup as SignupFlowOptions).passwordValidation?.(password)
 
-    let user = await this._findUserByToken(resetToken as string)
+    let user = await this._findUserByToken(resetToken)
     const [hashedPassword] = hashPassword(password, {
       salt: user.salt,
     })

packages/auth-providers/firebase/web/src/__tests__/firebase.test.tsx

@@ -151,7 +151,7 @@ function getFirebaseAuth(customProviderHooks?: {
   ) => (rolesToCheck: string | string[]) => boolean
 }) {
   const { useAuth, AuthProvider } = createAuth(
-    firebaseMockClient as FirebaseClient,
+    firebaseMockClient,
     customProviderHooks,
   )
   const { result } = renderHook(() => useAuth(), {

packages/auth-providers/supertokens/web/src/__tests__/supertokens.test.tsx

@@ -85,7 +85,7 @@ function getSuperTokensAuth(customProviderHooks?: {
   ) => (rolesToCheck: string | string[]) => boolean
 }) {
   const { useAuth, AuthProvider } = createAuth(
-    superTokensMockClient as SuperTokensAuth,
+    superTokensMockClient,
     customProviderHooks,
   )
   const { result } = renderHook(() => useAuth(), {

packages/babel-config/src/common.ts

@@ -162,10 +162,7 @@ export const getPathsFromTypeScriptConfig = (
       continue
     }
     const aliasKey = key.replace('/*', '')
-    const aliasValue = path.join(
-      absoluteBase,
-      (value as string)[0].replace('/*', ''),
-    )
+    const aliasValue = path.join(absoluteBase, value[0].replace('/*', ''))
 
     pathsObj[aliasKey] = aliasValue
   }

packages/babel-config/src/plugins/babel-plugin-redwood-cell.ts

@@ -55,7 +55,7 @@ export default function ({ types: t }: { types: typeof types }): PluginObj {
         let name
         if (declaration.type === 'VariableDeclaration') {
           const id = declaration.declarations[0].id as types.Identifier
-          name = id.name as string
+          name = id.name
         }
         if (declaration.type === 'FunctionDeclaration') {
           name = declaration?.id?.name

packages/babel-config/src/plugins/babel-plugin-redwood-graphql-options-extract.ts

@@ -2,7 +2,7 @@ import type { NodePath, PluginObj, PluginPass, types } from '@babel/core'
 
 // This extracts the options passed to the graphql function and stores them in an exported variable so they can be imported elsewhere.
 
-const exportVariableName = '__rw_graphqlOptions' as const
+const exportVariableName = '__rw_graphqlOptions'
 
 function optionsConstNode(
   t: typeof types,

packages/babel-config/src/plugins/babel-plugin-redwood-mock-cell-data.ts

@@ -212,7 +212,7 @@ export const getCellMetadata = (p: string) => {
         const id = declaration.declarations[0].id as types.Identifier
 
         namedExports.push({
-          name: id.name as string,
+          name: id.name,
           type: 'variable',
         })
       } else if (declaration.type === 'FunctionDeclaration') {

packages/babel-config/src/plugins/babel-plugin-redwood-otel-wrapping.ts

@@ -101,7 +101,7 @@ function wrapExportNamedDeclaration(
     if (param.type === 'ObjectPattern') {
       const objectProperties = param.properties.filter(
         (p) => p.type === 'ObjectProperty',
-      ) as types.ObjectProperty[]
+      )
       originalFunctionArgumentsWithoutDefaults.push(
         t.objectExpression(
           objectProperties.map((p) => {
@@ -122,7 +122,7 @@ function wrapExportNamedDeclaration(
       } else if (param.left.type === 'ObjectPattern') {
         const objectProperties = param.left.properties.filter(
           (p) => p.type === 'ObjectProperty',
-        ) as types.ObjectProperty[]
+        )
         originalFunctionArgumentsWithoutDefaults.push(
           t.objectExpression(
             objectProperties.map((p) => {

packages/cli/src/testLib/cells.ts

@@ -113,7 +113,7 @@ export const getNamedExports = (ast: types.Node): NamedExports[] => {
       if (declaration.type === 'VariableDeclaration') {
         const id = declaration.declarations[0].id as types.Identifier
         namedExports.push({
-          name: id.name as string,
+          name: id.name,
           type: 'variable',
         })
       } else if (declaration.type === 'FunctionDeclaration') {
@@ -240,7 +240,7 @@ const getFields = (field: FieldNode): any => {
       node.selectionSet?.selections.forEach((subField) => {
         switch (subField.kind) {
           case Kind.FIELD:
-            obj[field.name.value].push(getFields(subField as FieldNode))
+            obj[field.name.value].push(getFields(subField))
             break
           case Kind.FRAGMENT_SPREAD:
             // TODO: Maybe this will also be needed, right now it's accounted for to not crash in the tests

packages/codemods/src/lib/cells.ts

@@ -113,7 +113,7 @@ export const getNamedExports = (ast: types.Node): NamedExports[] => {
       if (declaration.type === 'VariableDeclaration') {
         const id = declaration.declarations[0].id as types.Identifier
         namedExports.push({
-          name: id.name as string,
+          name: id.name,
           type: 'variable',
         })
       } else if (declaration.type === 'FunctionDeclaration') {
@@ -240,7 +240,7 @@ const getFields = (field: FieldNode): any => {
       node.selectionSet?.selections.forEach((subField) => {
         switch (subField.kind) {
           case Kind.FIELD:
-            obj[field.name.value].push(getFields(subField as FieldNode))
+            obj[field.name.value].push(getFields(subField))
             break
           case Kind.FRAGMENT_SPREAD:
             // TODO: Maybe this will also be needed, right now it's accounted for to not crash in the tests

packages/context/src/store.ts

@@ -13,5 +13,5 @@ export const getAsyncStoreInstance = () => {
   if (!CONTEXT_STORAGE) {
     CONTEXT_STORAGE = new AsyncLocalStorage<Map<string, GlobalContext>>()
   }
-  return CONTEXT_STORAGE as AsyncLocalStorage<Map<string, GlobalContext>>
+  return CONTEXT_STORAGE
 }

packages/eslint-plugin/src/service-type-annotations.ts

@@ -74,7 +74,7 @@ export const serviceTypeAnnotations = createRule({
             }
 
             // Switch from the estree type to the typescript-eslint type
-            const tsID = vd.id as TSESTree.Identifier
+            const tsID = vd.id
 
             // If there's no type annotation, then we should add one
             if (!tsID.typeAnnotation) {

packages/graphql-server/src/globalContextStore.ts

@@ -13,5 +13,5 @@ export const getAsyncStoreInstance = () => {
   if (!CONTEXT_STORAGE) {
     CONTEXT_STORAGE = new AsyncLocalStorage<Map<string, GlobalContext>>()
   }
-  return CONTEXT_STORAGE as AsyncLocalStorage<Map<string, GlobalContext>>
+  return CONTEXT_STORAGE
 }

packages/graphql-server/src/plugins/useRedwoodLogger.ts

@@ -219,7 +219,7 @@ export const useRedwoodLogger = (
       })
     },
     onParse({ params }) {
-      const options = params.options as any
+      const options = params.options
 
       const envelopLogger = childLogger.child({
         ...options,
@@ -232,7 +232,7 @@ export const useRedwoodLogger = (
       }
     },
     onValidate({ params }) {
-      const options = params.options as any
+      const options = params.options
 
       const envelopLogger = childLogger.child({
         ...options,

packages/internal/src/ast.ts

@@ -79,7 +79,7 @@ export const getNamedExports = (ast: types.Node): NamedExports[] => {
       if (declaration.type === 'VariableDeclaration') {
         const id = declaration.declarations[0].id as types.Identifier
         namedExports.push({
-          name: id.name as string,
+          name: id.name,
           type: 'variable',
           location: {
             line: id.loc?.start.line ?? 1,

packages/internal/src/gql.ts

@@ -62,7 +62,7 @@ const getFields = (field: FieldNode): any => {
       node.selectionSet?.selections.forEach((subField) => {
         switch (subField.kind) {
           case Kind.FIELD:
-            obj[field.name.value].push(getFields(subField as FieldNode))
+            obj[field.name.value].push(getFields(subField))
             break
           case Kind.FRAGMENT_SPREAD:
             // TODO: Maybe this will also be needed, right now it's accounted for to not crash in the tests

packages/prerender/src/babelPlugins/utils.ts

@@ -8,8 +8,8 @@ import mime from 'mime-types'
 // Not sure if possible in actually running builds
 export function convertToDataUrl(assetPath: string) {
   try {
-    const base64AssetContents = fs.readFileSync(assetPath as string, 'base64')
-    const mimeType = mime.lookup(assetPath as string)
+    const base64AssetContents = fs.readFileSync(assetPath, 'base64')
+    const mimeType = mime.lookup(assetPath)
     return `data:${mimeType};base64,${base64AssetContents}`
   } catch {
     console.warn(`Could not read file ${assetPath} for conversion to data uri`)

packages/router/src/util.ts

@@ -83,8 +83,6 @@ const coreParamTypes: Record<string, ParamType> = {
   },
 }
 
-type SupportedRouterParamTypes = keyof typeof coreParamTypes
-
 /**
  * Determine if the given route is a match for the given pathname. If so,
  * extract any named params and return them in an object.
@@ -145,8 +143,7 @@ export function matchPath(
     const params = providedParams.reduce<Record<string, unknown>>(
       (acc, value, index) => {
         const [name, transformName] = routeParamsDefinition[index]
-        const typeInfo =
-          allParamTypes[transformName as SupportedRouterParamTypes]
+        const typeInfo = allParamTypes[transformName]
 
         let transformedValue: string | unknown = value
         if (typeof typeInfo?.parse === 'function') {
@@ -192,7 +189,7 @@ export function getRouteRegexAndParams(
   // /recipe/{id} -> /recipe/([^/$1*]+)
   for (const [_name, type, match] of routeParams) {
     // `undefined` matcher if `type` is not supported
-    const matcher = allParamTypes[type as SupportedRouterParamTypes]?.match
+    const matcher = allParamTypes[type]?.match
 
     // Get the regex as a string, or default regexp if `match` is not specified
     const typeRegexp = matcher?.source || '[^/]+'

packages/structure/src/ide.ts

@@ -265,7 +265,7 @@ export abstract class FileNode extends BaseNode {
     if (typeof this.text === 'undefined') {
       throw new Error('undefined file ' + this.filePath)
     }
-    return createTSMSourceFile_cached(this.filePath, this.text!)
+    return createTSMSourceFile_cached(this.filePath, this.text)
   }
   @lazy() get basenameNoExt() {
     return basenameNoExt(this.filePath)

packages/structure/src/model/RWRoute.ts

@@ -67,7 +67,7 @@ export class RWRoute extends BaseNode {
     }
     if (tsm.Node.isJsxAttribute(a)) {
       const init = a.getInitializer()
-      if (tsm.Node.isStringLiteral(init!)) {
+      if (tsm.Node.isStringLiteral(init)) {
         return init.getLiteralValue()
       }
     }
@@ -189,9 +189,9 @@ export class RWRoute extends BaseNode {
     }
     if (tsm.Node.isJsxAttribute(a)) {
       const init = a.getInitializer()
-      if (tsm.Node.isJsxExpression(init!)) {
+      if (tsm.Node.isJsxExpression(init)) {
         const expr = init.getExpression()
-        if (tsm.Node.isIdentifier(expr!)) {
+        if (tsm.Node.isIdentifier(expr)) {
           return expr
         }
       }
@@ -236,7 +236,7 @@ export class RWRoute extends BaseNode {
     }
     if (tsm.Node.isJsxAttribute(a)) {
       const init = a.getInitializer()
-      if (tsm.Node.isStringLiteral(init!)) {
+      if (tsm.Node.isStringLiteral(init)) {
         return init
       }
     }
@@ -269,7 +269,7 @@ export class RWRoute extends BaseNode {
     }
     if (this.isPrivate && this.isNotFound) {
       yield err(
-        this.jsxNode!,
+        this.jsxNode,
         "The 'Not Found' page cannot be within a <PrivateSet> or a <Private> tag",
       )
     }
@@ -369,7 +369,7 @@ export class RWRoute extends BaseNode {
         // If it is explicitly set to true
         // e.g. <Route prerender={true} />
         return tsm.Node.isTrueLiteral(init.getExpression())
-      } else if (tsm.Node.isStringLiteral(init!)) {
+      } else if (tsm.Node.isStringLiteral(init)) {
         // If its using the incorrect string form, we're accepting it as true
         // e.g. <Route prerender="true" />
         const literalValue = init.getLiteralValue()
@@ -387,7 +387,7 @@ export class RWRoute extends BaseNode {
     }
     if (tsm.Node.isJsxAttribute(a)) {
       const init = a.getInitializer()
-      if (tsm.Node.isStringLiteral(init!)) {
+      if (tsm.Node.isStringLiteral(init)) {
         return init.getLiteralValue()
       }
     }

packages/structure/src/model/util/advanced_path_parser.ts

@@ -8,14 +8,14 @@ export function advanced_path_parser(route: string) {
   const paramTypeRanges: [number, number][] = []
   for (const param of route.matchAll(/\{([^}]+)\}/g)) {
     const [paramName, paramType] = param[1].split(':')
-    const index = param.index! + 1
+    const index = param.index + 1
     paramRanges.push([index, index + paramName.length])
     if (paramType) {
       const typeIndex = index + paramName.length + 2
       paramTypeRanges.push([typeIndex, typeIndex + paramType.length])
     }
   }
-  const punctuationIndexes = [...route.matchAll(/[{}:]/g)].map((x) => x.index!)
-  const slashIndexes = [...route.matchAll(/[\/]/g)].map((x) => x.index!)
+  const punctuationIndexes = [...route.matchAll(/[{}:]/g)].map((x) => x.index)
+  const slashIndexes = [...route.matchAll(/[\/]/g)].map((x) => x.index)
   return { punctuationIndexes, slashIndexes, paramRanges, paramTypeRanges }
 }

packages/structure/src/x/URL.ts

@@ -33,7 +33,7 @@ export function URL_toFile(uriOrFilePath: string, sep = path_sep): string {
   if (!isAbsolute(p)) {
     throw new Error('absolute path expected: ' + p)
   }
-  return p!
+  return p
 }
 
 const FILE_SCHEME = 'file://'

packages/vite/src/devFeServer.ts

@@ -145,7 +145,7 @@ async function createServer() {
   const routeHandler = await createReactStreamingHandler(
     {
       routes,
-      clientEntryPath: rwPaths.web.entryClient as string,
+      clientEntryPath: rwPaths.web.entryClient,
       getStylesheetLinks: (route) => {
         // In dev route is a RouteSpec, with additional properties
         return getCssLinks({ rwPaths, route: route as RouteSpec, vite })

packages/vite/src/rsc/rscBuildEntriesFile.ts

@@ -40,7 +40,7 @@ export async function rscBuildEntriesMappings(
       serverBuildOutput.find(
         (item) =>
           'moduleIds' in item &&
-          item.moduleIds.includes(clientEntryFiles[name] as string),
+          item.moduleIds.includes(clientEntryFiles[name]),
       )?.fileName
 
     if (entryFile) {
@@ -68,7 +68,7 @@ export async function rscBuildEntriesMappings(
       serverBuildOutput.find(
         (item) =>
           'moduleIds' in item &&
-          item.moduleIds.includes(clientEntryFiles[name] as string),
+          item.moduleIds.includes(clientEntryFiles[name]),
       )?.fileName
 
     if (entryFile) {

packages/vite/src/rsc/rscStudioHandlers.ts

@@ -47,7 +47,7 @@ const processRenderRscStream = async (
 
     pipeable.on('end', () => {
       const resultBuffer = Buffer.concat(chunks)
-      const resultString = resultBuffer.toString('utf-8') as string
+      const resultString = resultBuffer.toString('utf-8')
       resolve(resultString)
     })
 

packages/web/src/components/Metadata.tsx

@@ -36,7 +36,7 @@ const propToMetaTag = (
     // plain text
     const attributes = {
       [options['attr']]: parentKey,
-      content: parentValue as string,
+      content: parentValue,
     }
     return <meta {...attributes} />
   }

packages/web/src/components/cell/createSuspendingCell.tsx

@@ -55,7 +55,7 @@ export function createSuspendingCell<
   function SuspendingSuccess(props: SuspendingSuccessProps) {
     const { queryRef, suspenseQueryResult, userProps } = props
     const { data, networkStatus } = useReadQuery<DataObject>(queryRef)
-    const afterQueryData = afterQuery(data as DataObject)
+    const afterQueryData = afterQuery(data)
 
     const queryResultWithNetworkStatus: SuspenseCellQueryResult = {
       ...suspenseQueryResult,