chore(lint): enable 'typescript-eslint/no-unnecessary-type-assertion' #11284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:chore
Josh-Walker-GM
commented
Aug 16, 2024
Comment on lines
-166
to
+165
| absoluteBase, | ||
| (value as string)[0].replace('/*', ''), | ||
| ) | ||
| const aliasValue = path.join(absoluteBase, value[0].replace('/*', '')) |
There was a problem hiding this comment.
I think this highlights that the type definition above is a little wrong?
type CompilerOptionsForPaths = {
compilerOptions: { baseUrl: string; paths: string }
}I might have thought that paths would be a record of strings and not just a string itself?
Josh-Walker-GM
force-pushed
the
jgmw/chore-lint-no-unnecessary-type-assertion
branch
from
cf04bbb
to
0771cb6
Compare
Josh-Walker-GM
deleted the
jgmw/chore-lint-no-unnecessary-type-assertion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables
typescript-eslint/no-unnecessary-type-assertionand addresses points raised.