Define process.env.NODE_ENV in build process.
#10553
Conversation
| @@ -31,6 +31,9 @@ export async function rscBuildClient(clientEntryFiles: Record<string, string>) { | |||
|
|
|||
| const clientBuildOutput = await viteBuild({ | |||
| envFile: false, | |||
| define: { | |||
There was a problem hiding this comment.
Does having define here, and in the other viteBuild invocations, interfere with what we do in getMergedConfig.ts where we set define: getEnvVarDefinitions()?
There was a problem hiding this comment.
I just checked, and I don't think any of the places where I'm setting define makes use of redwoodPluginVite, but then again I don't think redwoodPluginVite is used at all? (I could be wrong.)
There was a problem hiding this comment.
It's used by every Redwood App (that has Vite setup, which they all do by default now)
If you look in the kitchen-sink test project inside web/vite.config.ts it imports it as redwood from @redwoodjs/vite.
And then at least rscBuildAnalyze uses that config file by doing configFile: rwPaths.web.viteConfig
There was a problem hiding this comment.
Oooh, ok! Let me look into that!
There was a problem hiding this comment.
I don't think it'll interfere; the only place where I modify, and we include the default config is here:
, and thenNODE_ENV will be replaced appropriately as part of the build process.
Tobbe
added
release:fix
…uth-store * 'main' of github.com:redwoodjs/redwood: chore(router): Add more code comments to analyzeRoutes (#10569) RSC: No need to use memo or useMemo in the server router (#10568) RSC: getViteConfig in rscWorker (#10567) Split RSC and RSA handling in rscWorker (#10565) RSC: Extract the fetchRSC function (#10564) RSC: Fix TODO regarding SSR in client.ts (#10562) Docs: QoL Updates to Contributing.md (#10561) Added warning note to not add WebAuthn (#10231) fix(rsc): Load all css links to support css with rsc (#10544) fix(cli): Add deprecation notice for edgio deployment (#10551) Define `process.env.NODE_ENV` in build process. (#10553) chore(docs): Update dbAuth and Supabase middleware READMEs (#10552) chore(deps): Upgrade React 19 to beta 20240508 (#10560) Revert "chore(deps): React beta 20240508 (#10558)" (#10559) chore(deps): React beta 20240508 (#10558) fix(functions): Fix context variable warning/error (#10556) fix(functions): Mock context in function test template (#10555) chore(middleware): Format code and comments and fix comment grammar (#10554)
This fixes a bug where RSC would complain about the Client using the development version of React whilst the server was using the production version. The reason for this is
that Vite's bundling process it replaces "process.env.NODE_ENV" with the values specified in the define configuration. Supplying this configuration option during the build
process ensures that we're using the same version of React.