fix(rsc): Load all css links to support css with rsc #10544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
release:fix
peterp
reviewed
May 11, 2024
Comment on lines
+159
to
+162
| createElement(ServerEntry, { | ||
| location: { pathname: rscId }, | ||
| css: cssLinks, | ||
| }), |
There was a problem hiding this comment.
Really nice implementation 🥇
There was a problem hiding this comment.
Thanks! The way that Tobbe and Danny laid the groundwork here made it somewhat easy to pass the collected css links through and have them loaded.
peterp
approved these changes
May 11, 2024
There was a problem hiding this comment.
This seems like a solid implementation to me! But will defer the final decision/ review to @Tobbe.
@Josh-Walker-GM Maybe it would be wise to keep a note of where/how we could potentially improve performance (Like you've done in the PR), but in the code?
Tobbe
approved these changes
May 11, 2024
dac09
added a commit
that referenced
this pull request
May 15, 2024
…uth-store * 'main' of github.com:redwoodjs/redwood: chore(router): Add more code comments to analyzeRoutes (#10569) RSC: No need to use memo or useMemo in the server router (#10568) RSC: getViteConfig in rscWorker (#10567) Split RSC and RSA handling in rscWorker (#10565) RSC: Extract the fetchRSC function (#10564) RSC: Fix TODO regarding SSR in client.ts (#10562) Docs: QoL Updates to Contributing.md (#10561) Added warning note to not add WebAuthn (#10231) fix(rsc): Load all css links to support css with rsc (#10544) fix(cli): Add deprecation notice for edgio deployment (#10551) Define `process.env.NODE_ENV` in build process. (#10553) chore(docs): Update dbAuth and Supabase middleware READMEs (#10552) chore(deps): Upgrade React 19 to beta 20240508 (#10560) Revert "chore(deps): React beta 20240508 (#10558)" (#10559) chore(deps): React beta 20240508 (#10558) fix(functions): Fix context variable warning/error (#10556) fix(functions): Mock context in function test template (#10555) chore(middleware): Format code and comments and fix comment grammar (#10554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently we don't have good css support with RSC. Therefore the pages are unstyled and look ugly.
Changes
Documentcomponent which ultimately causes them to be inserted into the HTML stream as link tags.preinitcalls. It's no longer used and can be revived from the git history if needed.Notes
preinitworking or we can stop loading some of these css assets by determining if they need to be loaded or not based on the url we're responding to.