-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(redirect): Add docs for redirect routes #10374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-redirect-docs
branch
from
March 31, 2024 15:36
35a9972
to
f77ee8b
Compare
jtoar
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just a few minor things but looks good
Thanks @jtoar! Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Apr 2, 2024
…nto feat/register-middleware * 'feat/register-middleware' of github.com:dac09/redwood: feat(router): Allow redirect routes to use route names as target (redwoodjs#10376) chore(babel-config): switch to vitest (redwoodjs#10361) docs(redirect): Add docs for redirect routes (redwoodjs#10374) chore(changesets): Automatically find PR number (redwoodjs#10377) chore(deps): Upgrade `lru-cache` (redwoodjs#10378) chore(e2e): use tarsync for syncing framework state to project (redwoodjs#10379)
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Apr 2, 2024
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were no docs for
<Route path="/some/path" redirect="/some/other/path" />
This PR adds docs for the
redirect
prop