Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(redirect): Add docs for redirect routes #10374

Merged
merged 10 commits into from
Apr 2, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 30, 2024

There were no docs for <Route path="/some/path" redirect="/some/other/path" />

This PR adds docs for the redirect prop

@Tobbe Tobbe added the release:docs This PR only updates docs label Mar 30, 2024
@Tobbe Tobbe added this to the chore milestone Mar 30, 2024
@Tobbe Tobbe requested a review from jtoar March 30, 2024 21:28
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few minor things but looks good

docs/docs/router.md Outdated Show resolved Hide resolved
docs/docs/router.md Outdated Show resolved Hide resolved
docs/docs/router.md Outdated Show resolved Hide resolved
docs/docs/router.md Outdated Show resolved Hide resolved
Tobbe and others added 3 commits April 2, 2024 09:16
@Tobbe Tobbe merged commit e795ded into redwoodjs:main Apr 2, 2024
45 checks passed
@Tobbe Tobbe deleted the tobbe-redirect-docs branch April 2, 2024 07:55
dac09 added a commit to dac09/redwood that referenced this pull request Apr 2, 2024
…nto feat/register-middleware

* 'feat/register-middleware' of github.com:dac09/redwood:
  feat(router): Allow redirect routes to use route names as target (redwoodjs#10376)
  chore(babel-config): switch to vitest (redwoodjs#10361)
  docs(redirect): Add docs for redirect routes (redwoodjs#10374)
  chore(changesets): Automatically find PR number (redwoodjs#10377)
  chore(deps): Upgrade `lru-cache` (redwoodjs#10378)
  chore(e2e): use tarsync for syncing framework state to project (redwoodjs#10379)
Josh-Walker-GM pushed a commit that referenced this pull request Apr 2, 2024
Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com>
@ahaywood ahaywood modified the milestones: next-release-patch, v7.4.0 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants