Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changesets): Automatically find PR number #10377

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Mar 30, 2024

Try to automatically find the PR on GitHub that corresponds to the current git branch if no pr number is provided on the command line.

This allows for a workflow where you can do
git push -u origin tobbe-changesets-find-pr
and create a PR on GitHub, and then go back to your terminal and just run
yarn changesets
to get a changesets file with all the info you just entered on GitHub, without having to memorize the PR number

It's also nice if you're helping a contributor to just being able to check out their branch and run yarn changesets to get a changesets file with the correct template

@Tobbe Tobbe added changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users) labels Mar 30, 2024
@Tobbe Tobbe added this to the chore milestone Mar 30, 2024
@Tobbe Tobbe requested a review from jtoar March 30, 2024 23:01
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and looks good to me

@jtoar jtoar merged commit c5fb177 into redwoodjs:main Apr 1, 2024
46 of 52 checks passed
ahaywood pushed a commit that referenced this pull request Apr 2, 2024
Try to automatically find the PR on GitHub that corresponds to the
current git branch if no pr number is provided on the command line.

This allows for a workflow where you can do
`git push -u origin tobbe-changesets-find-pr`
and create a PR on GitHub, and then go back to your terminal and just
run
`yarn changesets`
to get a changesets file with all the info you just entered on GitHub,
without having to memorize the PR number

It's also nice if you're helping a contributor to just being able to
check out their branch and run `yarn changesets` to get a changesets
file with the correct template
@Tobbe Tobbe deleted the tobbe-changesets-find-pr branch April 2, 2024 07:06
dac09 added a commit to dac09/redwood that referenced this pull request Apr 2, 2024
…nto feat/register-middleware

* 'feat/register-middleware' of github.com:dac09/redwood:
  feat(router): Allow redirect routes to use route names as target (redwoodjs#10376)
  chore(babel-config): switch to vitest (redwoodjs#10361)
  docs(redirect): Add docs for redirect routes (redwoodjs#10374)
  chore(changesets): Automatically find PR number (redwoodjs#10377)
  chore(deps): Upgrade `lru-cache` (redwoodjs#10378)
  chore(e2e): use tarsync for syncing framework state to project (redwoodjs#10379)
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants