Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to start the api server unless RSC is enabled #10275

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Don't try to start the api server unless RSC is enabled #10275

merged 3 commits into from
Mar 22, 2024

Conversation

cannikin
Copy link
Member

Closes #10274

@cannikin cannikin added release:chore This PR is a chore (means nothing for users) fixture-ok Override the test project fixture check labels Mar 22, 2024
@cannikin cannikin added this to the next-release milestone Mar 22, 2024
Josh-Walker-GM
Josh-Walker-GM approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@Josh-Walker-GM Josh-Walker-GM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah this is better/less friction when you have RSCs enabled.

@Josh-Walker-GM Josh-Walker-GM merged commit f8c4795 into main Mar 22, 2024
44 checks passed
@Josh-Walker-GM Josh-Walker-GM deleted the rc-rsc-serve branch March 22, 2024 19:03
@Josh-Walker-GM Josh-Walker-GM mentioned this pull request Mar 22, 2024
Closed
1 task
@thedavidprice
Copy link
Contributor

marking this as RSC milestone. It got pulled into next and was throwing errors. Let me know otherwise.

@thedavidprice thedavidprice modified the milestones: next-release, RSC Mar 27, 2024
thedavidprice pushed a commit that referenced this pull request Mar 27, 2024
@cannikin @thedavidprice
Don't try to start the api server unless RSC is enabled (#10275)
27802cf 
Closes #10274
thedavidprice added a commit that referenced this pull request Mar 27, 2024
@thedavidprice
Revert "Don't try to start the api server unless RSC is enabled (#10275…
544d580 
…)"

This reverts commit 27802cf.
@cannikin
Copy link
Member Author

Hmm, the RSC example photo app has no /api directory so depends on this change to start the serve process. I forget how the next branch works, I though we just used that for docs?

@jtoar
Copy link
Contributor

jtoar commented Mar 28, 2024

@cannikin the next branch is where all our stable releases are cut from 😂

@cannikin
Copy link
Member Author

Yeah sorry, just realized this was pulled from next and not from main: carry on! :)

@Josh-Walker-GM Josh-Walker-GM modified the milestones: RSC, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Walker-GM Josh-Walker-GM Josh-Walker-GM approved these changes

Assignees
No one assigned
Labels
fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

Do not require web argument for serve command when serving RSC apps
4 participants
@cannikin @thedavidprice @jtoar @Josh-Walker-GM