Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require web argument for serve command when serving RSC apps #10274

Closed
cannikin opened this issue Mar 22, 2024 · 0 comments · Fixed by #10275
Closed

Do not require web argument for serve command when serving RSC apps #10274

cannikin opened this issue Mar 22, 2024 · 0 comments · Fixed by #10275

Comments

@cannikin
Copy link
Member

cannikin commented Mar 22, 2024

Summary

Right now yarn rw serve assumes there is both a web and api side and so yarn rw serve with no additional arguments will always start both servers. If you try to launch both but either the web or api side is missing, you'll get an error.

However, in RSC-land, there is only one server. I should be able to use yarn rw serve without the web argument as it's the only server that exists anyway.

Detailed proposal

Update checks in packages/cli/src/commands/serve.js to not raise an error if an argument is left off when serving an RSC app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant