Skip to content

Aggregation loadall #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Dec 2, 2021
Merged

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Nov 22, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1688
Based on cover_aggregation branch (#1713)

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #1735 (e26e5c0) into master (d425227) will increase coverage by 0.16%.
The diff coverage is 100.00%.

❗ Current head e26e5c0 differs from pull request most recent head 18123dc. Consider uploading reports for the commit 18123dc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1735      +/-   ##
==========================================
+ Coverage   90.91%   91.08%   +0.16%     
==========================================
  Files          70       74       +4     
  Lines       14994    15605     +611     
==========================================
+ Hits        13632    14214     +582     
- Misses       1362     1391      +29     
Impacted Files Coverage Δ
redis/commands/search/aggregation.py 79.72% <100.00%> (+0.88%) ⬆️
tests/test_search.py 99.02% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 97.24% <0.00%> (ø)
redis/commands/redismodules.py 100.00% <0.00%> (ø)
tests/test_bloom.py 91.28% <0.00%> (ø)
redis/commands/bf/__init__.py 100.00% <0.00%> (ø)
redis/commands/bf/info.py 100.00% <0.00%> (ø)
redis/commands/bf/commands.py 95.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d425227...18123dc. Read the comment docs.

@chayim chayim added the 4.1.0 label Nov 29, 2021
@chayim chayim merged commit 8f5c1e6 into redis:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for FT.AGGREGATE with LOAD *
3 participants