Skip to content

Improve code coverage for aggregation tests #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 25, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Nov 15, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Add tests for some aggregation function that hadn't been tested yet.

Two things that were left uncovered (from aggregation.py):

  1. verbatim
  2. cursor

@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review November 15, 2021 13:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #1713 (0f68afd) into master (3838493) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   89.05%   89.52%   +0.47%     
==========================================
  Files          53       53              
  Lines       11078    11127      +49     
==========================================
+ Hits         9865     9961      +96     
+ Misses       1213     1166      -47     
Impacted Files Coverage Δ
redis/commands/search/aggregation.py 79.62% <ø> (+26.61%) ⬆️
tests/test_search.py 98.93% <100.00%> (+0.36%) ⬆️
redis/__init__.py 84.61% <0.00%> (-15.39%) ⬇️
tests/conftest.py 93.50% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9235a72...0f68afd. Read the comment docs.

@AvitalFineRedis AvitalFineRedis linked an issue Nov 15, 2021 that may be closed by this pull request
@AvitalFineRedis AvitalFineRedis mentioned this pull request Nov 22, 2021
4 tasks
@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 23, 2021
@chayim chayim changed the title Cover aggregation Improve code coverage for aggregation tests Nov 25, 2021
@chayim chayim merged commit 3de2e6b into redis:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aggregation tests for search library
3 participants