ci: add ESLint as blocking CI step #5347
Open
+42
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lint.yml reusable workflow that runs yarn lint - Update tests.yml to call lint workflow first - All test jobs now depend on lint passing
Add inline eslint-disable comments for imports from api/dist which doesn't exist in CI (clean checkout without build artifacts).
Lint is now run as a blocking step before tests start, making this Slack-reporting-only step redundant.
pawelangelow
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pd-redis and
valkirilov
as code owners
Contributor
Code Coverage - Integration Tests
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success5487 tests passing in 704 suites. Report generated by 🧪jest coverage report action from e92effd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds ESLint as a blocking step in CI before tests run:
lint.ymlworkflow - Runs ESLint as a required check that blocks test execution if linting failsapi/distfolderChanges
Testing
CI pipeline runs on the branch.
Pull Request opened by Augment Code with guidance from the PR author
Note
Introduce a new ESLint workflow that runs before tests and remove legacy lint-report steps; add ESLint import exceptions for desktop server API imports.
/.github/workflows/lint.ymlrunningyarn lint./.github/workflows/tests.yml, addlintjob and require it forfrontend-tests,backend-tests, andintegration-tests.tests-frontend.ymlandtests-backend.yml.redisinsight/desktop/src/lib/server/server.tsto disableimport/extensionsforapi/distimports to satisfy ESLint.Written by Cursor Bugbot for commit e92effd. This will update automatically on new commits. Configure here.