Skip to content

Commit b10260d

Browse files
committed
ci: remove redundant Code analysis step from frontend and backend tests
Lint is now run as a blocking step before tests start, making this Slack-reporting-only step redundant.
1 parent 7bf014a commit b10260d

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

.github/workflows/tests-backend.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,15 +41,6 @@ jobs:
4141
FILENAME=$FILENAME DEPS="API dev" node .github/deps-audit-report.js &&
4242
curl -H "Content-type: application/json" --data @slack.$FILENAME -H "Authorization: Bearer $SLACK_AUDIT_REPORT_KEY" -X POST https://slack.com/api/chat.postMessage
4343
44-
- name: Code analysis
45-
run: |
46-
FILENAME=api.lint.audit.json
47-
WORKDIR="."
48-
49-
yarn lint:api -f json -o $FILENAME || true &&
50-
FILENAME=$FILENAME WORKDIR=$WORKDIR TARGET="API" node .github/lint-report.js &&
51-
curl -H "Content-type: application/json" --data @$WORKDIR/slack.$FILENAME -H "Authorization: Bearer $SLACK_AUDIT_REPORT_KEY" -X POST https://slack.com/api/chat.postMessage
52-
5344
- name: Unit tests API
5445
timeout-minutes: 20
5546
run: yarn --cwd redisinsight/api/ test:cov --ci --silent

.github/workflows/tests-frontend.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -35,19 +35,6 @@ jobs:
3535
FILENAME=$FILENAME DEPS="UI dev" node .github/deps-audit-report.js &&
3636
curl -H "Content-type: application/json" --data @slack.$FILENAME -H "Authorization: Bearer $SLACK_AUDIT_REPORT_KEY" -X POST https://slack.com/api/chat.postMessage
3737
38-
- name: Code analysis
39-
run: |
40-
FILENAME=ui.lint.audit.json
41-
WORKDIR="."
42-
43-
yarn lint:ui -f json -o $FILENAME || true &&
44-
FILENAME=$FILENAME WORKDIR=$WORKDIR TARGET="UI" node .github/lint-report.js &&
45-
curl -H "Content-type: application/json" --data @$WORKDIR/slack.$FILENAME -H "Authorization: Bearer $SLACK_AUDIT_REPORT_KEY" -X POST https://slack.com/api/chat.postMessage
46-
47-
yarn lint -f json -o $FILENAME || true &&
48-
FILENAME=$FILENAME WORKDIR=$WORKDIR TARGET="REST" node .github/lint-report.js &&
49-
curl -H "Content-type: application/json" --data @$WORKDIR/slack.$FILENAME -H "Authorization: Bearer $SLACK_AUDIT_REPORT_KEY" -X POST https://slack.com/api/chat.postMessage
50-
5138
- name: Unit tests UI
5239
timeout-minutes: 30
5340
run: yarn test:cov --ci --silent

0 commit comments

Comments
 (0)