Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual environment approach no longer supported for badfish command #235

Closed
dustinblack opened this issue Jul 13, 2022 · 1 comment
Closed

Comments

@dustinblack
Copy link
Collaborator

dustinblack commented Jul 13, 2022

Latest Badfish has some issues on using virtual python environment and venv will not be supported in the long run.

We have replaced most uses of venv in #229, but one usage remains in the bootstrap role:

badfish_cmd: "/root/badfish/src/badfish/badfish.py -u {{ lab_ipmi_user }} -p {{ lab_ipmi_password }} -i /root/badfish/config/idrac_interfaces.yml -H mgmt-"

This var is used in the tasks here:
https://github.com/redhat-performance/JetSki/blob/ab0bba1094226119fca1f7feb4bdc3b73d6c67e9/ansible-ipi-install/roles/bootstrap/tasks/20_reprovision_nodes.yml

Per #229 (comment) from Murali, we cannot use the containerized approach that we are using elsewhere in this case because we also run this in a pipeline with Airflow where Jetski is containerized.

We need to replace the badfish venv command here with a straight standalone CLI method.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant