Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared-labs-prep role use of badfish via virtual env fails with module not found. #186

Closed
mordechai opened this issue Nov 30, 2021 · 4 comments · Fixed by #188 or cloud-bulldozer/airflow-kubernetes#90

Comments

@mordechai
Copy link

Shared-labs-prep role use of badfish via virtual env fails with module not found.
When reproduced you'll notice looping of rescue attempts to Reset Idrace because badfish --clear-jobs --force fails with:
src/badfish/badfish.py\", line 23, in \n from helpers.async_lru import alru_cache\nModuleNotFoundError

This happens in shared-lab-prep tasks 10_redfish_queue.yml and 20_set_director_mode.yml which use virtual env to run badfish.

To workaround this you can specify the git path of badfish and remove use of virtual env.
Likely a better fix would be to re-purpose the podman setup of badfish which happens in a later role to be used here, and avoid the duplication of badfish setup, additionally badfish now offers badfish as os package.

@github-actions
Copy link

Thank you for raising this issue

@grafuls
Copy link

grafuls commented Nov 30, 2021

We introduced a change recently that inadvertently affected the virtualenv setup. We are likely not going to revert this as using the virtualenv solution is not something we would like to support in the long run.
If you would like to keep using this workflow I suggest you include on your scripts the symlink action for the library to find the missing module.

ln -s {BADFISH_REPO_PATH}/src/helpers {VIRTUALENV_PATH}/lib/python3.10/site-packages/helpers

We will amend the docs to include this additional instruction for the time being.

@mukrishn
Copy link

@mordechai could you test this patch - mukrishn@bd3a788.
As a long term solution, will update this piece to use podman command.

@mordechai
Copy link
Author

@mukrishn 'badfish missing library #188 works thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants