Set vcs-uri annotation on podman by feloy · Pull Request #6746 · redhat-developer/odo

feloy · 2023-04-18T09:52:50Z

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6493

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

netlify · 2023-04-18T09:52:57Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`1ddc37f`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/643feb87455ea10008ad71c1

odo-robot · 2023-04-18T09:59:11Z

OpenShift Unauthenticated Tests on commit 6522e64 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T09:59:12Z

NoCluster Tests on commit 6522e64 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T10:01:46Z

Unit Tests on commit 6522e64 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T10:07:38Z

Validate Tests on commit 6522e64 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T10:22:56Z

Kubernetes Tests on commit 6522e64 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T10:28:34Z

Windows Tests (OCP) on commit 6522e64 finished with errors.
View logs: TXT HTML

odo-robot · 2023-04-18T10:28:49Z

Kubernetes Docs Tests on commit 912f6d1 finished successfully.
View logs: TXT HTML

odo-robot · 2023-04-18T10:29:38Z

OpenShift Tests on commit 6522e64 finished with errors.
View logs: TXT HTML

feloy · 2023-04-18T16:13:47Z

Podman v3 cannot get annotations from a running pod, so it is not possible to test it on GitHub ACtion with Podman v3 for now.

rm3l · 2023-04-19T08:30:47Z

tests/integration/cmd_dev_test.go

 			BeforeEach(func() {
 				if podman {
-					Skip("Not implemented yet on Podman - see https://github.com/redhat-developer/odo/issues/6493")
+					Skip("Getting annotations is not available with Podman v3")


Would it be possible to be more specific (as we are able to determine the actual version of Podman) and skip the test only if it is < v4? So that we can still have this tested with Podman v4..
I am perfectly okay if you think it is not worth the effort for now.

It would be great to look into how we could have tests on both Podman v3 and v4, but that's the scope of #6583

tests/helper/helper_podman.go

sonarqubecloud · 2023-04-19T13:33:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

feloy · 2023-04-19T15:28:57Z

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [362.577 seconds]
odo list with devfile when a component created in 'app' application when dev is running on cluster [BeforeEach] verifying the managedBy Version in the odo list output should show managedBy Version
  [BeforeEach] /go/odo_1/tests/integration/cmd_devfile_list_test.go:133
  [It] /go/odo_1/tests/integration/cmd_devfile_list_test.go:181
[...]
Expected
      <string>:   __
       /  \__     Developing using the "lnlzfy" Devfile
       \__/  \    Namespace: cmd-devfile-list-test181opf
       /  \__/    odo version: v3.9.0
       \__/
      
      â†ª Running on the cluster in Dev mode
       â€¢  Waiting for Kubernetes resources  ...
       âš   Pod is Pending
       âœ“  Pod is Running
       â€¢  Syncing files into the container  ...
      ↵
 âœ“  Syncing files into the container [1s]
       â€¢  Building your application in container (command: install)  ...
      ↵
 âœ“  Building your application in container (command: install) [4s]
       â€¢  Executing the application (command: run)  ...
       â€¢  Waiting for the application to be ready  ...
      
  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 13:52:16.515

odo dev command tests checking if odo dev matches local Devfile K8s resources and remote resources when odo dev is executed to run a devfile containing a k8s resource with apply command [BeforeEach] should have deleted the old resource and created the new resource
  [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:730
  [It] /go/odo_1/tests/integration/cmd_dev_test.go:757
[...]
  Expected
      <string>: Updating Component...
      
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
      
      Pushing files...
      
      
      File /tmp/3884646612/devfile.yaml changed
       â€¢  Waiting for Kubernetes resources  ...
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
      
       â€¢  Waiting for Kubernetes resources  ...
      Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
      
       â€¢  Waiting for Kubernetes resources  ...
       â€¢  Syncing files into the container  ...
      ↵
 âœ“  Syncing files into the container [846ms]
       â€¢  Building your application in container (command: build)  ...
      ↵
 âœ“  Building your application in container (command: build) [3s]
      
      â†ª Building & Pushing Image: quay.io/unknown-account/myimage
       â€¢  Building image locally  ...
      build -t quay.io/unknown-account/myimage -f /tmp/3884646612/Dockerfile /tmp/3884646612
      ↵
 âœ“  Building image locally [8ms]
       â€¢  Pushing image to container registry  ...
      push quay.io/unknown-account/myimage
      ↵
 âœ“  Pushing image to container registry [5ms]
      
      â†ª Deploying Kubernetes Component: my-new-k8s-component
       â€¢  Creating resource Deployment/my-new-k8s-component  ...
      ↵
 âœ“  Creating resource Deployment/my-new-k8s-component 
      
      â†ª Deploying Kubernetes Component: my-new-openshift-component
       â€¢  Creating resource Deployment/my-new-openshift-component  ...
      ↵
 âœ“  Creating resource Deployment/my-new-openshift-component 
      ↵
 âœ“  Finished executing the application (command: start) [5m]
       â€¢  Executing the application (command: start)  ...
       â€¢  Waiting for the application to be ready  ...
      
  to contain substring
      <string>: Dev mode
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 13:58:41.795

 [FAILED] [362.663 seconds]
odo list with devfile devfile has missing metadata when projectType and language is missing when the component is pushed [BeforeEach] should show 'nodejs' for 'Type' in odo list
  [BeforeEach] /go/odo_1/tests/integration/cmd_devfile_list_test.go:354
  [It] /go/odo_1/tests/integration/cmd_devfile_list_test.go:363
[...]
  Expected
      <string>:   __
       /  \__     Developing using the "aname" Devfile
       \__/  \    Namespace: cmd-devfile-list-test363jta
       /  \__/    odo version: v3.9.0
       \__/
      
      â†ª Running on the cluster in Dev mode
       â€¢  Waiting for Kubernetes resources  ...
       âš   Pod is Pending
       âœ“  Pod is Running
       â€¢  Syncing files into the container  ...
      ↵
 âœ“  Syncing files into the container [989ms]
       â€¢  Building your application in container (command: defaultbuild)  ...
      ↵
 âœ“  Building your application in container (command: defaultbuild) [41s]
       â€¢  Executing the application (command: defaultrun)  ...
       âœ—  Finished executing the application (command: defaultrun) [6s]
       â€¢  Waiting for the application to be ready  ...
      
  to contain substring
      <string>: [Ctrl+c] - Exit
  In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 14:00:52.143

openshift-ci · 2023-04-19T15:29:01Z

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

Details

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [362.577 seconds]
odo list with devfile when a component created in 'app' application when dev is running on cluster [BeforeEach] verifying the managedBy Version in the odo list output should show managedBy Version
 [BeforeEach] /go/odo_1/tests/integration/cmd_devfile_list_test.go:133
 [It] /go/odo_1/tests/integration/cmd_devfile_list_test.go:181
[...]
Expected
     <string>:   __
      /  \__     Developing using the "lnlzfy" Devfile
      \__/  \    Namespace: cmd-devfile-list-test181opf
      /  \__/    odo version: v3.9.0
      \__/
     
     â†ª Running on the cluster in Dev mode
      â€¢  Waiting for Kubernetes resources  ...
      âš   Pod is Pending
      âœ“  Pod is Running
      â€¢  Syncing files into the container  ...
     ↵
âœ“  Syncing files into the container [1s]
      â€¢  Building your application in container (command: install)  ...
     ↵
âœ“  Building your application in container (command: install) [4s]
      â€¢  Executing the application (command: run)  ...
      â€¢  Waiting for the application to be ready  ...
     
 to contain substring
     <string>: [Ctrl+c] - Exit
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 13:52:16.515

odo dev command tests checking if odo dev matches local Devfile K8s resources and remote resources when odo dev is executed to run a devfile containing a k8s resource with apply command [BeforeEach] should have deleted the old resource and created the new resource
 [BeforeEach] /go/odo_1/tests/integration/cmd_dev_test.go:730
 [It] /go/odo_1/tests/integration/cmd_dev_test.go:757
[...]
 Expected
     <string>: Updating Component...
     
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
     
     Pushing files...
     
     
     File /tmp/3884646612/devfile.yaml changed
      â€¢  Waiting for Kubernetes resources  ...
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
     
      â€¢  Waiting for Kubernetes resources  ...
     Error occurred on Push - watch command was unable to push component: unable to delete remote resources: unable to delete resource: Deployment/my-k8s-component: timeout while waiting for "my-k8s-component" resource to be deleted
     
      â€¢  Waiting for Kubernetes resources  ...
      â€¢  Syncing files into the container  ...
     ↵
âœ“  Syncing files into the container [846ms]
      â€¢  Building your application in container (command: build)  ...
     ↵
âœ“  Building your application in container (command: build) [3s]
     
     â†ª Building & Pushing Image: quay.io/unknown-account/myimage
      â€¢  Building image locally  ...
     build -t quay.io/unknown-account/myimage -f /tmp/3884646612/Dockerfile /tmp/3884646612
     ↵
âœ“  Building image locally [8ms]
      â€¢  Pushing image to container registry  ...
     push quay.io/unknown-account/myimage
     ↵
âœ“  Pushing image to container registry [5ms]
     
     â†ª Deploying Kubernetes Component: my-new-k8s-component
      â€¢  Creating resource Deployment/my-new-k8s-component  ...
     ↵
âœ“  Creating resource Deployment/my-new-k8s-component 
     
     â†ª Deploying Kubernetes Component: my-new-openshift-component
      â€¢  Creating resource Deployment/my-new-openshift-component  ...
     ↵
âœ“  Creating resource Deployment/my-new-openshift-component 
     ↵
âœ“  Finished executing the application (command: start) [5m]
      â€¢  Executing the application (command: start)  ...
      â€¢  Waiting for the application to be ready  ...
     
 to contain substring
     <string>: Dev mode
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 13:58:41.795

[FAILED] [362.663 seconds]
odo list with devfile devfile has missing metadata when projectType and language is missing when the component is pushed [BeforeEach] should show 'nodejs' for 'Type' in odo list
 [BeforeEach] /go/odo_1/tests/integration/cmd_devfile_list_test.go:354
 [It] /go/odo_1/tests/integration/cmd_devfile_list_test.go:363
[...]
 Expected
     <string>:   __
      /  \__     Developing using the "aname" Devfile
      \__/  \    Namespace: cmd-devfile-list-test363jta
      /  \__/    odo version: v3.9.0
      \__/
     
     â†ª Running on the cluster in Dev mode
      â€¢  Waiting for Kubernetes resources  ...
      âš   Pod is Pending
      âœ“  Pod is Running
      â€¢  Syncing files into the container  ...
     ↵
âœ“  Syncing files into the container [989ms]
      â€¢  Building your application in container (command: defaultbuild)  ...
     ↵
âœ“  Building your application in container (command: defaultbuild) [41s]
      â€¢  Executing the application (command: defaultrun)  ...
      âœ—  Finished executing the application (command: defaultrun) [6s]
      â€¢  Waiting for the application to be ready  ...
     
 to contain substring
     <string>: [Ctrl+c] - Exit
 In [BeforeEach] at: /go/odo_1/tests/helper/helper_run.go:54 @ 04/19/23 14:00:52.143

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feloy · 2023-04-19T15:29:39Z

/override windows-integration-test/Windows-test

[FAILED] [148.887 seconds]
odo describe/list binding command tests [AfterEach] when creating a component with a spec binding (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
  [AfterEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3741/tests/integration/cmd_describe_list_binding_test.go:25
  [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3741/tests/integration/cmd_describe_list_binding_test.go:787
[...]
[oc] Unable to connect to the server: dial tcp 158.177.79.34:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

openshift-ci · 2023-04-19T15:29:43Z

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

[FAILED] [148.887 seconds]
odo describe/list binding command tests [AfterEach] when creating a component with a spec binding (service in namespace "") when Starting a Pg service when running dev session when changing the current namespace should list the binding with --namespace flag
 [AfterEach] C:/Users/Administrator.ANSIBLE-TEST-VS/3741/tests/integration/cmd_describe_list_binding_test.go:25
 [It] C:/Users/Administrator.ANSIBLE-TEST-VS/3741/tests/integration/cmd_describe_list_binding_test.go:787
[...]
[oc] Unable to connect to the server: dial tcp 158.177.79.34:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feloy closed this Apr 18, 2023

feloy reopened this Apr 18, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 18, 2023

feloy added 3 commits April 18, 2023 16:51

Set vcs-uri annotation on podman

b538c42

Integration test

90de015

Disable test with Podman v3

fd9f6e0

feloy force-pushed the feature-6493/vcs-uri-annotation branch from 19920d2 to fd9f6e0 Compare April 18, 2023 15:01

feloy changed the title ~~[WIP] Set vcs-uri annotation on podman~~ Set vcs-uri annotation on podman Apr 18, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Apr 18, 2023

feloy requested review from rm3l and valaparthvi April 18, 2023 16:14

rm3l reviewed Apr 19, 2023

View reviewed changes

Make test run with podman v4

36a7a25

feloy requested a review from rm3l April 19, 2023 11:28

rm3l requested changes Apr 19, 2023

View reviewed changes

tests/helper/helper_podman.go Outdated Show resolved Hide resolved

openshift-ci bot assigned rm3l Apr 19, 2023

Fix displaying error

1ddc37f

feloy requested a review from rm3l April 19, 2023 13:24

rm3l approved these changes Apr 19, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 19, 2023

openshift-merge-robot merged commit b843ce8 into redhat-developer:main Apr 19, 2023

Conversation

feloy commented Apr 18, 2023

Uh oh!

netlify bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for odo-docusaurus-preview canceled.

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

odo-robot bot commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feloy commented Apr 18, 2023

Uh oh!

rm3l Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 19, 2023

Uh oh!

feloy commented Apr 19, 2023

Uh oh!

openshift-ci bot commented Apr 19, 2023

Uh oh!

feloy commented Apr 19, 2023

Uh oh!

openshift-ci bot commented Apr 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading

odo-robot bot commented Apr 18, 2023 •

edited

Loading