filetree_create fixes to export workflow job templates #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivarmu
requested changes
Mar 7, 2025
roles/filetree_create/tasks/all.yml
Outdated
There was a problem hiding this comment.
We are not going back with these names. For AAP2.5, aap_* are the correct ones and are aligned with the main collection:
So, please adapt your input variables to the new names for this collection.
roles/filetree_create/tasks/main.yml
Outdated
| @@ -50,7 +50,6 @@ | |||
| args: | |||
| apply: | |||
| tags: "{{ input_tag | to_yaml }}" | |||
| tags: "{{ valid_tags }}" | |||
There was a problem hiding this comment.
What's the matter with this? This is required to run correctly when you only need to export one or more objet types, but not all of them.
2. Add double quotes for `*_nodes` lines that may contain special characters (like #) 3. Fix Truthy value for `survey_enabled` coming in as `True` or `False` instead of `true` or `false`
* misc: inventory name unification * fix: missing change * fix: missing change after merge
…hat-cop/infra.controller_configuration#22 (redhat-cop#85) * Update controller_workflow_job_templates.j2 to fix issue found at redhat-cop/infra.controller_configuration#22 * add changelog
ivarmu
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running a fairly straight-forward playbook (as alluded to in the docs), I get the following failures:
Of note, I still get failures when attempting to export Applications, I didn't need this functionality but perhaps we should look into fixing downstream resources exports.
How should this be tested?
Include filetre_create role.
Is there a relevant Issue open for this?
No that I'm aware of, but as mentioned above filetree_create role didn't work for me without these changes.