inventory name unification singular > plural #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemkalit
requested review from
silvinux,
ivarmu,
adonisgarciac and
a team
as code owners
|
Sorry about this... but could you address the conflicts, please? |
|
Could you also align with #75? |
|
Those changes was removed by #77, @Tompage1994 could you restore this change? It is again creating discrepancy... |
|
Sorry for being too hasty but now I see the changes, maybe I was looking to wrong branch or something :/. |
l3acon
pushed a commit
to l3acon/aap_configuration_extended
that referenced
this pull request
Mar 25, 2025
* misc: inventory name unification * fix: missing change * fix: missing change after merge
ivarmu
added a commit
that referenced
this pull request
Mar 31, 2025
* changes to make workflow job templates export, still fails on applications * 1. Fix duplicate `limit:` line (#84) 2. Add double quotes for `*_nodes` lines that may contain special characters (like #) 3. Fix Truthy value for `survey_enabled` coming in as `True` or `False` instead of `true` or `false` * inventory name unification singular > plural (#72) * misc: inventory name unification * fix: missing change * fix: missing change after merge * Update controller_workflow_job_templates.j2 to fix issue found at redhat-cop/infra.controller_configuration#22 (#85) * Update controller_workflow_job_templates.j2 to fix issue found at redhat-cop/infra.controller_configuration#22 * add changelog * sync and remove unnecessary changes * try to keep verbosity --------- Co-authored-by: Lenny Shirley <ircmaster@hotmail.com> Co-authored-by: przemkalit <przemyslaw.kalitowski@natek.eu> Co-authored-by: Ivan Aragonés Muniesa <26822043+ivarmu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR renames
inventorytoinventories. Since the other objects are in plural form and the endpoint API also is in the plural form, I believe this one should be as well.How should this be tested?
Manually.
Is there a relevant Issue open for this?
N/A
Other Relevant info, PRs, etc
N/A