Fixed qos2_publish_handled_ logic. #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qos2_publish_handled_ was inserted and erased but not referenced. When PUBLISH QoS2 packet is received, if qos2_publish_handled_ has the packet_id then on_publish isn't called. (Exactly once delivery) See #49.
Codecov Report
@@ Coverage Diff @@
## master #824 +/- ##
==========================================
+ Coverage 82.73% 82.75% +0.01%
==========================================
Files 62 62
Lines 8657 8667 +10
==========================================
+ Hits 7162 7172 +10
Misses 1495 1495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qos2_publish_handled_ was inserted and erased but not referenced.
When PUBLISH QoS2 packet is received, if qos2_publish_handled_ has the
packet_id then on_publish isn't called. (Exactly once delivery)
See #49.