Changed QoS2 publish handling polcy simpler. #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client's publish handler used to be called when pubrel is received. I thought that it was the best way to avoid duplicate publish. However, I found better way. I introduced the `std::set<std::uint16_t>` that stores packet_id. The member variable name is qos2_publish_handled_. When publish is received, check qos2_publish_handled_. If packet_id has already been stored, client's publish handler is not called, but pubrec is sent to the client. If packet_id is not stored, call the client's publish handler and stores packet_id into qos2_publish_handled_. When pubrel is received, the packet_id in qos2_publish_handled_ is removed.
redboltz
added a commit
that referenced
this pull request
Aug 8, 2021
qos2_publish_handled_ was inserted and erased but not referenced. When PUBLISH QoS2 packet is received, if qos2_publish_handled_ has the packet_id then on_publish isn't called. (Exactly once delivery) See #49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client's publish handler used to be called when pubrel is received.
I thought that it was the best way to avoid duplicate publish.
However, I found better way.
I introduced the
std::set<std::uint16_t>that stores packet_id.The member variable name is qos2_publish_handled_.
When publish is received, check qos2_publish_handled_.
If packet_id has already been stored, client's publish handler is not
called, but pubrec is sent to the client.
If packet_id is not stored, call the client's publish handler and
stores packet_id into qos2_publish_handled_.
When pubrel is received, the packet_id in qos2_publish_handled_ is
removed.