CheckoutPricing: Coupons

lib/recurly.js

@@ -1,14 +1,17 @@
 /*jshint -W058 */
 
-import type from 'component-type';
 import clone from 'component-clone';
+import chunk from 'lodash.chunk';
 import merge from 'lodash.merge';
 import jsonp from 'jsonp';
 import qs from 'qs';
 import Emitter from 'component-emitter';
+import Promise from 'promise';
 import errors from './errors';
 import version from './version';
 import bankAccount from './recurly/bank-account';
+import coupon from './recurly/coupon';
+import giftcard from './recurly/giftcard';
 import {token} from './recurly/token';
 import {factory as Frame} from './recurly/frame';
 import {factory as ApplePay} from './recurly/apple-pay';
@@ -17,13 +20,10 @@ import {deprecated as deprecatedPaypal} from './recurly/paypal/strategy/direct';
 import {Bus} from './recurly/bus';
 import {Fraud} from './recurly/fraud';
 import {HostedFields, FIELD_TYPES} from './recurly/hosted-fields';
-import {Message} from './recurly/message';
 import CheckoutPricing from './recurly/pricing/checkout';
 import SubscriptionPricing from './recurly/pricing/subscription';
 import uuid from './util/uuid';
 
-import giftcard from './recurly/giftcard';
-
 const debug = require('debug')('recurly');
 
 /**
@@ -129,7 +129,7 @@ export class Recurly extends Emitter {
 
     options = clone(options);
 
-    if (type(options) === 'string') options = { publicKey: options };
+    if (typeof options === 'string') options = { publicKey: options };
 
     options = normalizeOptions(options)
 
@@ -159,7 +159,7 @@ export class Recurly extends Emitter {
       this.config.parent = options.parent;
     }
 
-    if (type(options.fields) === 'object') {
+    if (typeof options.fields === 'object') {
       merge(this.config.fields, options.fields);
     }
 
@@ -258,7 +258,7 @@ export class Recurly extends Emitter {
       throw errors('not-configured');
     }
 
-    if ('function' == type(data)) {
+    if (typeof data === 'function') {
       done = data;
       data = {};
     }
@@ -278,6 +278,65 @@ export class Recurly extends Emitter {
     }
   }
 
+  /**
+   * Pipelines a request across several requests
+   *
+   * Chunks are made of `data[by]`` in `size`. If any request errors,
+   * the entire pipeline errors
+   *
+   * - Ignores 404s until done
+   * - Immediately rejects other errors
+   * - Collects and concats array responses
+   * - Immediately resolves non-array responses
+   *
+   * @param {String} method
+   * @param {String} route
+   * @param {Object} data
+   * @param {Array} data.by must be an Array
+   * @param {String} by
+   * @param {Number} size=100
+   * @param {Function} done
+   * @private
+   */
+
+  pipedRequest ({ method, route, data, by, size }) {
+    let results = [];
+    let empties = [];
+
+    const chunks = chunk(data[by], size).map(piece => {
+      return Object.assign({}, data, { [by]: piece });
+    });
+
+    if (chunks.length === 0) {
+      return Promise.denodeify(this.request.bind(this))(method, route, data);
+    }
+
+    return new Promise((resolve, reject) => {
+      const part = (err, res) => {
+        // if we have any errors that are not 404, reject
+        if (err) {
+          if (err.code === 'not-found') empties.push(err);
+          else return reject(err);
+        }
+
+        // If the response is an array, collect it; otherwise, resolve with it
+        if (res) {
+          if (Array.isArray(res)) results.push(res);
+          else return resolve(res);
+        }
+
+        if ((results.length + empties.length) === chunks.length) {
+          // if we have some results and some 404s, resolve with results
+          // otherwise, reject with the first 404
+          if (results.length > 0) resolve(results.reduce((acc, cur) => acc.concat(cur)));
+          else reject(empties[0]);
+        }
+      };
+
+      chunks.forEach(dataChunk => this.request(method, route, dataChunk, part));
+    });
+  }
+
   /**
    * Issues an API request over xhr.
    *
@@ -374,7 +433,7 @@ export class Recurly extends Emitter {
 }
 
 Recurly.prototype.Frame = Frame;
-Recurly.prototype.coupon = require('./recurly/coupon');
+Recurly.prototype.coupon = coupon;
 Recurly.prototype.giftcard = giftcard;
 Recurly.prototype.ApplePay = ApplePay;
 Recurly.prototype.PayPal = PayPal;

lib/recurly/apple-pay.js

@@ -1,12 +1,12 @@
 import Emitter from 'component-emitter';
 import errors from '../errors';
+import {CheckoutPricing} from './pricing/checkout';
 import {SubscriptionPricing} from './pricing/subscription';
 import {normalize} from '../util/normalize';
 import {FIELDS} from './token';
 
 const debug = require('debug')('recurly:apple-pay');
 
-const SESSION_TIMEOUT = 300000; // 5m
 const APPLE_PAY_API_VERSION = 2;
 const APPLE_PAY_ADDRESS_MAP = {
   first_name: 'givenName',

lib/recurly/bank-account.js

@@ -1,5 +1,4 @@
 import each from 'component-each';
-import type from 'component-type';
 import {normalize} from '../util/normalize';
 import errors from '../errors';
 
@@ -75,7 +74,7 @@ function token (options, done) {
   var input = data.values;
   var userErrors = validate(input);
 
-  if ('function' !== type(done)) {
+  if (typeof done !== 'function') {
     throw errors('missing-callback');
   }
 
@@ -109,12 +108,12 @@ function token (options, done) {
 function bankInfo (options, done) {
   debug('bankInfo');
 
-  if ('function' !== type(done)) {
+  if (typeof done !== 'function') {
     throw errors('missing-callback');
   }
 
   var routingNumber = options && options.routingNumber;
-  if (!routingNumber || type(routingNumber) !== 'string') {
+  if (!routingNumber || typeof routingNumber !== 'string') {
     return done(errors('validation', { fields: ['routingNumber'] }));
   }
 
@@ -135,7 +134,7 @@ function validate (input) {
   var errors = [];
 
   each(requiredFields, function(field){
-    if (!input[field] || type(input[field]) !== 'string') {
+    if (!input[field] || typeof input[field] !== 'string') {
       errors.push(field);
     }
   });

lib/recurly/coupon.js

@@ -1,38 +1,38 @@
-var type = require('component-type');
-var debug = require('debug')('recurly:coupon');
-var errors = require('../errors');
+import errors from '../errors';
 
-module.exports = coupon;
+const debug = require('debug')('recurly:coupon');
+
+const CHUNK_SIZE = 100;
 
 /**
  * Coupon mixin.
  *
- * Retrieves coupon information for the `plan`. The `callback` signature
- * is `err, plan` where `err` may be a request or server error, and `plan`
- * is a representation of the requested plan.
+ * Retrieves coupon information for the `coupon` and optional `plan`.
+ * The `callback` signature is `err, coupon` where `err` may be a request
+ * or server error, and `coupon` is a representation of the requested coupon.
  *
  * @param {Object} options
- * @param {Function} callback
+ * @param {String} options.coupon coupon code
+ * @param {String} [options.plan] plan code
+ * @param {Array[String]} [options.plans] plan codes
+ * @param {Function} done
  */
 
-function coupon (options, callback) {
+export default function coupon (options = {}, done) {
   debug('%j', options);
 
-  if ('function' !== type(callback)) {
-    throw errors('missing-callback');
-  }
-
-  if ('object' !== type(options)) {
-    throw errors('invalid-options');
-  }
+  let {coupon, plans, plan, currency} = options;
 
-  if (!('plan' in options)) {
-    throw errors('missing-plan');
-  }
+  if (!coupon) throw errors('missing-coupon');
+  if (typeof done !== 'function') throw errors('missing-callback');
 
-  if (!('coupon' in options)) {
-    throw errors('missing-coupon');
-  }
+  if (!plans && plan) plans = [plan];
 
-  this.request('get', '/plans/' + options.plan + '/coupons/' + options.coupon, options, callback);
+  this.pipedRequest({
+    method: 'get',
+    route: `/coupons/${coupon}`,
+    data: { plan_codes: plans, currency },
+    by: 'plan_codes',
+    size: CHUNK_SIZE,
+  }).nodeify(done);
 }

lib/recurly/giftcard.js

@@ -1,4 +1,3 @@
-import type from 'component-type';
 import errors from '../errors';
 
 const debug = require('debug')('recurly:giftcard');
@@ -17,11 +16,11 @@ const debug = require('debug')('recurly:giftcard');
 export default function giftcard (options, callback) {
   debug('%j', options);
 
-  if ('function' !== type(callback)) {
+  if (typeof callback !== 'function') {
     throw errors('missing-callback');
   }
 
-  if ('object' !== type(options)) {
+  if (typeof options !== 'object') {
     throw errors('invalid-options');
   }
 

lib/recurly/paypal/strategy/index.js

@@ -6,7 +6,6 @@ import errors from '../../../errors';
 
 const debug = require('debug')('recurly:paypal:strategy');
 
-const PAYPAL_CLIENT_URI = 'https://www.paypalobjects.com/api/checkout.js';
 const DISPLAY_OPTIONS = [
   'amount',
   'currency',

lib/recurly/plan.js

@@ -1,4 +1,3 @@
-var type = require('component-type');
 var debug = require('debug')('recurly:plan');
 
 module.exports = plan;
@@ -17,11 +16,11 @@ module.exports = plan;
 function plan (code, callback) {
   debug('%s', code);
 
-  if ('function' != type(callback)) {
+  if (typeof callback !== 'function') {
     throw new Error('Missing callback');
   }
 
-  if ('undefined' == type(code)) {
+  if (typeof code === 'undefined') {
     return callback(new Error('Missing plan code'));
   }