-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CheckoutPricing: Coupons #385
Commits on Nov 7, 2017
-
- Manages a single coupon on the item set Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 95a861e - Browse repository at this point
Copy the full SHA 95a861eView commit details -
Adds CheckoutPricing discount calculations
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4c5f81 - Browse repository at this point
Copy the full SHA e4c5f81View commit details -
Updates recurly.coupon for new endpoint
- /plans/:plan_code/coupons/:coupon_code -> /coupons/:id - optional `plan_id` as `plan` Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3be292 - Browse repository at this point
Copy the full SHA f3be292View commit details -
- Vestigial IE8 support Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e26485d - Browse repository at this point
Copy the full SHA e26485dView commit details -
Updates coupon module structure
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53b622b - Browse repository at this point
Copy the full SHA 53b622bView commit details -
Updates CheckoutPricing for new coupon getter
- Still WIP: need to determine API capabilities for plan-specific and plan-agnostic coupons Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 75af47d - Browse repository at this point
Copy the full SHA 75af47dView commit details -
Updates coupon specs for new endpoint
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f84178 - Browse repository at this point
Copy the full SHA 0f84178View commit details -
- For spreading a long set request across multiple requests Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c513752 - Browse repository at this point
Copy the full SHA c513752View commit details -
Adds multiple plan code support to coupon getter
- Uses pipedRequest to spread a large number of plans - Adds expectation for invoice-level coupon properties Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2e73e2a - Browse repository at this point
Copy the full SHA 2e73e2aView commit details -
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b8df59c - Browse repository at this point
Copy the full SHA b8df59cView commit details -
Updates CheckoutPricing coupon handler for new types
- Supports discounts against adjustments, single subscriptions, and free trials Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8503c99 - Browse repository at this point
Copy the full SHA 8503c99View commit details -
Improves recurly.pipedRequest response handling
- Ignores 404s until done - Immediately rejects other errors - Collects and concats array responses - Immediately resolves non-array responses Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b75213f - Browse repository at this point
Copy the full SHA b75213fView commit details -
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 19f22f9 - Browse repository at this point
Copy the full SHA 19f22f9View commit details -
Updates SubscriptionPricing.coupon to receive objects
- Avoids an extraneous API call when assigning a coupon to a subscription Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for adb4523 - Browse repository at this point
Copy the full SHA adb4523View commit details -
Fixes CheckoutPricing plan currency handling
- CheckoutPricing must accept SubscriptionPricing instances before they are given plans Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd08d09 - Browse repository at this point
Copy the full SHA bd08d09View commit details -
Fixes CheckoutPricing/Calculations sub calculation safety
- Checks for a subscription price before adding it to the price, since price is not guaranteed to exist Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 712f670 - Browse repository at this point
Copy the full SHA 712f670View commit details -
Adds EmbeddedSubscriptionPricing
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4430bb4 - Browse repository at this point
Copy the full SHA 4430bb4View commit details -
Fixes SubscriptionPricing reprice safety
- Cehcks for plan presence Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a96fa2 - Browse repository at this point
Copy the full SHA 2a96fa2View commit details -
Fixes CheckoutPricing/Calculations trial detection
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 06b62b8 - Browse repository at this point
Copy the full SHA 06b62b8View commit details -
Ensures subscription safety in CheckoutPricing/Calculations
- Invalid subscriptions may exist on a CheckoutPricing - Excludes them when running checkout calculations - Stubs out Promise refactor in CheckoutPricing/Calculations Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 73b6e63 - Browse repository at this point
Copy the full SHA 73b6e63View commit details -
Applies Promise pattern to CheckoutPricing/Calculations
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0fab807 - Browse repository at this point
Copy the full SHA 0fab807View commit details -
Fixes checkout pricing free trial coupon application
- Free trial coupons may restrict the plans they work with. This implements a subscription filter for that case Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3860f7f - Browse repository at this point
Copy the full SHA 3860f7fView commit details -
Adds adjustment code uniqueness validator
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fcb7da7 - Browse repository at this point
Copy the full SHA fcb7da7View commit details -
- Prevents the change event from emitting. - Use this to prevent unwanted event looping Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c1b7e07 - Browse repository at this point
Copy the full SHA c1b7e07View commit details -
Narrows scope of reprice event silencer
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 18eca38 - Browse repository at this point
Copy the full SHA 18eca38View commit details -
Fixes itemization collector for checkouts with sub discounts
- Subscription-level discounts on CheckoutPricing recomputs subscription prices. This resulted in duplicate entires in `price.now.items` - This defers final itemized list creation to later in the process Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 576644b - Browse repository at this point
Copy the full SHA 576644bView commit details -
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a04476b - Browse repository at this point
Copy the full SHA a04476bView commit details -
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 59008b8 - Browse repository at this point
Copy the full SHA 59008b8View commit details -
Fixes CheckoutPricing/Calculations plan-specific discount filter
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 580312e - Browse repository at this point
Copy the full SHA 580312eView commit details -
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b2181c8 - Browse repository at this point
Copy the full SHA b2181c8View commit details -
Fixes SubscriptionPricing.reprice
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2fff200 - Browse repository at this point
Copy the full SHA 2fff200View commit details -
Adds coupon validity detection for new endpoint
- /v1/coupons will return coupons which may not necessarily match the requested plan codes, if they may also apply to adjustments - this adds a validity detection method to SubscriptionPricing coupon getter Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 70b3b98 - Browse repository at this point
Copy the full SHA 70b3b98View commit details -
- Compatible with new coupon validity checks Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 31a01ed - Browse repository at this point
Copy the full SHA 31a01edView commit details -
Fixes coupon validity method safety
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fbb652c - Browse repository at this point
Copy the full SHA fbb652cView commit details -
Fixes pipedRequest for empty sets
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dc8ecdf - Browse repository at this point
Copy the full SHA dc8ecdfView commit details -
Fixes CheckoutPricing.coupon set and calculations
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb0f52f - Browse repository at this point
Copy the full SHA eb0f52fView commit details -
Adds CheckoutPricing.coupon specs
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2aaa800 - Browse repository at this point
Copy the full SHA 2aaa800View commit details
Commits on Nov 8, 2017
-
Fixes CheckoutPricing fixed amount discount overrun
- Also fixes setup fee exclusion rules for discounts Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c5c70d - Browse repository at this point
Copy the full SHA 2c5c70dView commit details -
Fixes CheckoutPricing subscription coupon and gift card removal
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8011207 - Browse repository at this point
Copy the full SHA 8011207View commit details -
Adds decimalize pass to CheckoutPricing
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 193bb94 - Browse repository at this point
Copy the full SHA 193bb94View commit details -
Adds CheckoutPricing fixed amount discount soecs
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a15d81 - Browse repository at this point
Copy the full SHA 2a15d81View commit details -
Fixes CheckoutPricing free trial application reprice
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1b8eb55 - Browse repository at this point
Copy the full SHA 1b8eb55View commit details -
Fixes SubscriptionPricing fixed amount discounting of setup fees
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2852800 - Browse repository at this point
Copy the full SHA 2852800View commit details -
Adds CheckoutPricing discount specs
- Fixed amount coupons - subscription-level coupons - Free trial coupons Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1bbabe0 - Browse repository at this point
Copy the full SHA 1bbabe0View commit details
Commits on Nov 9, 2017
-
Adds recurly.pipedRequest defaults
Signed-off-by: Christopher Rogers <chrissrogers@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2362f17 - Browse repository at this point
Copy the full SHA 2362f17View commit details