Docs fix: UseCheckoutPricingInput subscriptions
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 778Details
💛 - Coveralls |
|
@javimbk Thanks for the contribution. We will be reviewing this and get back to you as soon as possible. |
rer7891
approved these changes
Oct 8, 2021
|
@javimbk Thanks for the contribution. This has been reviewed and merged. |
|
Thank you @rer7891 for the merge, I hope you build again the Storybook sometime soon so people can avoid this. Have a nice week! |
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.5) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.6) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error also in this section of the documentation.
Current state
currencycannot be passed in a subscription,currencyis meant to be passed on the root level ofUseCheckoutPricingInputand passing it on the subscription does absolutely nothing and should not be even passed according to the documentation when you scroll down.I am suggesting this change to avoid the confusion that went through me today for more time than I would care to admit.