-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 690Details
💛 - Coveralls |
I think this is a good stopgap solution to the issue occurring in |
chrissrogers
approved these changes
Apr 13, 2021
@@ -22805,7 +22805,7 @@ | |||
"lodash.pick": "^4.4.0", | |||
"nanoid": "^2.1.9", | |||
"promise": "^8.0.3", | |||
"qs": "^6.9.3", | |||
"qs": "^6.9.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks as well for these updates 👍
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.5) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
recurly-integrations
pushed a commit
that referenced
this pull request
Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.6) **Merged Pull Requests** - listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly)) - Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers)) - setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing)) - Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk)) - Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk)) - Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44)) - add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44)) - fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set the fraud property on RecurlyProvider like so:
We get this error:
in
node_modules/recurly.js/lib/recurly/fraud.js:63:26
The problem seems to be with the way that recurly's constructor works—if you provide options in the constructor, then the configure event fires and the call to
risk/info
fails without a Request object being set yet. The way the recurly instance is set up here in this PR is more like your e2e tests in the recurly-js repo itself, so configuration happens after everything gets set up, including therequest
property.