Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[composer] remove dependency on nette-to-symfony, very niche package that would require much work to be used in public #290

Merged
merged 2 commits into from
Jun 25, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/packages_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ jobs:
repository_name:
# must be repository name, e.g. https://github.com/rectorphp/rector-nette
- rectorphp/rector-nette
- rectorphp/rector-nette-to-symfony
- rectorphp/rector-symfony
- rectorphp/rector-laravel
- rectorphp/rector-phpunit
Expand Down
1 change: 0 additions & 1 deletion build/target-repository/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"rector/rector-symfony": "*",
"rector/rector-doctrine": "*",
"rector/rector-nette": "*",
"rector/rector-nette-to-symfony": "*",
"rector/rector-cakephp": "*"
}
}
1 change: 0 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"rector/rector-doctrine": "^0.11.5",
"rector/rector-laravel": "^0.11.1",
"rector/rector-nette": "^0.11.5",
"rector/rector-nette-to-symfony": "^0.11.3",
"rector/rector-phpunit": "^0.11.1",
"rector/rector-symfony": "^0.11.6",
"sebastian/diff": "^4.0.4",
Expand Down
44 changes: 0 additions & 44 deletions config/set/kdyby-to-symfony.php

This file was deleted.

6 changes: 0 additions & 6 deletions dev-docs/packages_ci_status.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,3 @@
* https://github.com/rectorphp/rector-cakephp
* ![](https://github.com/rectorphp/rector-cakephp/actions/workflows/tests.yaml/badge.svg)
* ![](https://github.com/rectorphp/rector-cakephp/actions/workflows/code_analysis.yaml/badge.svg)

## Nette to Symfony

* https://github.com/rectorphp/rector-nette-to-symfony
* ![](https://github.com/rectorphp/rector-nette-to-symfony/actions/workflows/tests.yaml/badge.svg)
* ![](https://github.com/rectorphp/rector-nette-to-symfony/actions/workflows/code_analysis.yaml/badge.svg)
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,12 @@

use PhpParser\Node;
use PhpParser\NodeVisitorAbstract;
use Rector\NodeCollector\NodeCollector\NodeRepository;
use Rector\NodeCollector\NodeCollector\ParsedNodeCollector;
use Rector\NodeCollector\NodeCollector\ParsedPropertyFetchNodeCollector;

final class NodeCollectorNodeVisitor extends NodeVisitorAbstract
{
public function __construct(
private NodeRepository $nodeRepository,
private ParsedNodeCollector $parsedNodeCollector,
private ParsedPropertyFetchNodeCollector $parsedPropertyFetchNodeCollector
) {
Expand Down
5 changes: 0 additions & 5 deletions packages/Set/ValueObject/SetList.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ final class SetList implements SetListInterface
*/
public const GMAGICK_TO_IMAGICK = __DIR__ . '/../../../config/set/gmagick_to_imagick.php';

/**
* @var string
*/
public const KDYBY_TO_SYMFONY = __DIR__ . '/../../../config/set/kdyby-to-symfony.php';

/**
* @var string
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
use Rector\Core\Rector\AbstractRector;
use Rector\FileSystemRector\ValueObject\AddedFileWithNodes;
use Rector\FileSystemRector\ValueObjectFactory\AddedFileWithNodesFactory;
use Rector\NetteToSymfony\NodeAnalyzer\NetteControlFactoryInterfaceAnalyzer;
use Rector\Nette\NodeAnalyzer\Component\NetteControlFactoryInterfaceAnalyzer;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Reflection\ReflectionProvider;
use PHPStan\Type\ObjectType;
use Rector\Core\NodeManipulator\ClassMethodManipulator;
use Rector\Core\Rector\AbstractRector;
use Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver;
use Rector\NodeCollector\StaticAnalyzer;
Expand All @@ -28,7 +27,6 @@
final class StaticCallOnNonStaticToInstanceCallRector extends AbstractRector
{
public function __construct(
private ClassMethodManipulator $classMethodManipulator,
private StaticAnalyzer $staticAnalyzer,
private ReflectionProvider $reflectionProvider,
private ParentClassScopeResolver $parentClassScopeResolver
Expand Down