[composer] remove dependency on nette-to-symfony, very niche package that would require much work to be used in public #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-less-nette-to-symfony
branch
4 times, most recently
from
5d6213b
to
410fd89
Compare
…that would require much work to be used in public
TomasVotruba
force-pushed
the
tv-less-nette-to-symfony
branch
2 times, most recently
from
827b67d
to
7d5f68e
Compare
TomasVotruba
force-pushed
the
tv-less-nette-to-symfony
branch
from
7d5f68e
to
5c07d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The https://github.com/rectorphp/rector-nette-to-symfony package proven useful for Nette to Symfony migrations. It a great source for learning about f2f migrations.
Yet, Rector as a tool has proven to be better in more common operations like framework upgrade, rather then this migration. Specific migration use specific framework version origin and target framework version and linked package was build for on Nette 2.2/3 to Symfony 4. Now it would rather fail on never version, as not maintained much.
Saying that we've decided to take it out of Rector core and keep it archived for anyone, who'll need a custom set to learn from for their own specific migration.