[SYCL][Graph] Throw exception when explicit add called on a graph recording a queue #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raph recording a queue Factorizes the exception throwing method when the explicit API is used on a graph recording a queue Improves the test while_recording to test throwing an invalid exception for the two explicit graph:add entry points. Addresses issue #271
mfrancepillois
added
the
Graph Implementation
mfrancepillois
changed the title
Bensuo
approved these changes
Aug 1, 2023
EwanC
approved these changes
Aug 1, 2023
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
Co-authored-by: Ewan Crawford <ewan@codeplay.com>
julianmi
approved these changes
Aug 2, 2023
mfrancepillois
added a commit
that referenced
this pull request
Aug 3, 2023
…ording a queue (#283) Factorizes the exception throwing method when the explicit API is used on a graph recording a queue Improves the test while_recording to test throwing an invalid exception for the two explicit graph:add entry points. Addresses issue #271 * Update sycl/source/detail/graph_impl.hpp Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> * Update sycl/test-e2e/Graph/Explicit/while_recording.cpp Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> * Update sycl/source/detail/graph_impl.hpp Co-authored-by: Ewan Crawford <ewan@codeplay.com> --------- Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> Co-authored-by: Ewan Crawford <ewan@codeplay.com>
mfrancepillois
added a commit
that referenced
this pull request
Aug 3, 2023
mfrancepillois
added a commit
that referenced
this pull request
Aug 3, 2023
EwanC
added a commit
that referenced
this pull request
Aug 10, 2023
…ording a queue (#283) Factorizes the exception throwing method when the explicit API is used on a graph recording a queue Improves the test while_recording to test throwing an invalid exception for the two explicit graph:add entry points. Addresses issue #271 * Update sycl/source/detail/graph_impl.hpp Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> * Update sycl/test-e2e/Graph/Explicit/while_recording.cpp Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> * Update sycl/source/detail/graph_impl.hpp Co-authored-by: Ewan Crawford <ewan@codeplay.com> --------- Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorizes the exception throwing method when the explicit API is used on a graph recording a queue Improves the test while_recording to test throwing an invalid exception for the two explicit graph:add entry points.
Addresses issue #271