Skip to content

Implement throwing an exception when using explicit API on graph in recording mode #271

Closed
@EwanC

Description

@EwanC

Implement specification defined behaviour for graph:add() around throwing an exception when used on a graph that's recording to a queue.

* Throws synchronously with error code `invalid` if a queue is recording
  commands to the graph.

The XFAIL in test https://github.com/reble/llvm/blob/sycl-graph-develop/sycl/test-e2e/Graph/Explicit/while_recording.cpp#L8 should be removed as part of implementing this behaviour.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Graph ImplementationRelated to DPC++ implementation and testingbugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions