[SYCL][Graph] Add error checking to make_edge #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bensuo
added
the
Graph Implementation
mfrancepillois
approved these changes
Jul 14, 2023
EwanC
reviewed
Jul 17, 2023
EwanC
reviewed
Jul 17, 2023
I've updated the unit tests to check the graph structure before and after adding a cycle which throws and is caught 👍 |
EwanC
approved these changes
Jul 17, 2023
reble
reviewed
Jul 17, 2023
- make_edge now checks for cycles - no_cycle_check property can now be passed to skip them - Various other error checks in make_edge - Generic depth first search mechanism added to graph_impl - New e2e tests for cycle checks - Unit tests for other basic errors
- Improve comments - Move visitNodeDepthFirst() to anonymouse namespace - Move cycle error test to Explicit folder
- Adds testing for the graph structure after a cycle error is caught to ensure it is unchanged.
Bensuo
force-pushed
the
ben/edge-error-checks
branch
from
8fac526 to
e0dc49c
Compare
julianmi
approved these changes
Jul 19, 2023
Bensuo
added a commit
that referenced
this pull request
Jul 31, 2023
- make_edge now checks for cycles - no_cycle_check property can now be passed to skip them - Various other error checks in make_edge - Generic depth first search mechanism added to graph_impl - New e2e tests for cycle checks - Unit tests for other basic errors - Prevent adding duplicate edges - Adds testing for the graph structure after a cycle error is caught to ensure it is unchanged. - Skip cycle checks when dst has no successors
EwanC
pushed a commit
that referenced
this pull request
Aug 10, 2023
- make_edge now checks for cycles - no_cycle_check property can now be passed to skip them - Various other error checks in make_edge - Generic depth first search mechanism added to graph_impl - New e2e tests for cycle checks - Unit tests for other basic errors - Prevent adding duplicate edges - Adds testing for the graph structure after a cycle error is caught to ensure it is unchanged. - Skip cycle checks when dst has no successors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94