Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master #8032

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Merge master #8032

merged 11 commits into from
Sep 20, 2024

Conversation

jedelbo
Copy link
Contributor

@jedelbo jedelbo commented Sep 20, 2024

What, How & Why?

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

github-actions bot and others added 10 commits August 30, 2024 09:57
Co-authored-by: jedelbo <572755+jedelbo@users.noreply.github.com>
* Removed redirect tests
* Removed one more location redirect test case
* Removed redirect tests
* Removed one more location redirect test case
* Removed 301/308 redirection support from App
* Updates from review
* Updated changelog after release
* Fixed misspelling and updated comment a bit
The function should ensure strict weak ordering. According to the current one
 {1, 0} == {0, 1} and {0, 1} == {2, 1}
but
 {1, 0} < {2, 1}

It is not possible to construct a failing test as the outcome very much depends
on how the runtime types are laid out.
Co-authored-by: jedelbo <572755+jedelbo@users.noreply.github.com>
Co-authored-by: jedelbo <572755+jedelbo@users.noreply.github.com>
Copy link

cla-bot bot commented Sep 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Michael Wilkerson-Barker.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Sep 20, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Michael Wilkerson-Barker.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jedelbo jedelbo merged commit b766f28 into community Sep 20, 2024
2 of 5 checks passed
@jedelbo jedelbo deleted the je/merge-master branch September 20, 2024 11:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants