You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the redirection 301/308 support is being removed, the tests are no longer needed. The first part of these changes is to remove the redirect tests.
Should we add a test that makes the synchronous CURL http lib follow redirects, and setup a redirecting server the issues a 308 and make sure we can sync with that?
Should we add a test that makes the synchronous CURL http lib follow redirects, and setup a redirecting server the issues a 308 and make sure we can sync with that?
I would be happy to do this in a separate PR - the test that I am adding for the CPP SDK will also be doing this.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Since the redirection 301/308 support is being removed, the tests are no longer needed. The first part of these changes is to remove the redirect tests.
Fixes #7942
☑️ ToDos
[ ] 📝 Changelog update[ ] C-API, if public C++ API changed[ ]bindgen/spec.yml
, if public C++ API changed