Prefer package ACL over @_spi
#5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Prefer `package` ACL over `@_spi`.
[SimplyDanny](https://github.com/SimplyDanny)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
SimplyDanny
force-pushed
the
use-package-acl
branch
from
b6607d2 to
0b4845d
Compare
SimplyDanny
force-pushed
the
use-package-acl
branch
from
0b4845d to
83bc7b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
@_spiworkaround was introduced in #4607 to make the build work forSwiftLintTestHelperin Xcode and SPM.With the new
packageaccess control modifier in Swift 5.9, the internal@_spiattribute doesn't seem to be needed to giveSwiftLintTestHelperaccess to internal symbols.@ryanaveo: You contributed #4607 back then. In your environment, would this change work?