-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix building tests in Xcode #4607
Merged
jpsim
merged 4 commits into
realm:main
from
ryanaveo:raveo-fix-xcode-building-on-0.50.1
Nov 30, 2022
Merged
Fix building tests in Xcode #4607
jpsim
merged 4 commits into
realm:main
from
ryanaveo:raveo-fix-xcode-building-on-0.50.1
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trying to use target SwiftLintTestHelpers
ryanaveo
force-pushed
the
raveo-fix-xcode-building-on-0.50.1
branch
from
November 29, 2022 23:59
8d089e8
to
ae75fef
Compare
Here's an example of your CHANGELOG entry: * Fix building tests in Xcode.
[ryanaveo](https://github.com/ryanaveo)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number) note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
jpsim
changed the title
Fix unable to build/test project on Xcode on release 0.51.0
Fix building tests in Xcode
Nov 30, 2022
jpsim
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryanaveo !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4606
SwiftLintTestHelpers is a testTarget in order to use @testable imports for SwiftLintFramework, which had previously failed to compile for release when the target was declared as a regular target with the following error:
However, this breaks building/testing the target in Xcode with the following error:
In order for SwiftLintTestHelpers to use internal symbols in SwiftLintFramework without using @testable import, we use @_spi imports instead. This fixes the issues when building on Xcode and for release.
Test Plan
Notes
Rule.swift needed to be broken into two files to pass the file length rule