-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix explicit_type_interface
when used in statements or in capture groups
#2321
Fix explicit_type_interface
when used in statements or in capture groups
#2321
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2321 +/- ##
=========================================
+ Coverage 92.01% 92.1% +0.08%
=========================================
Files 299 299
Lines 15084 15153 +69
=========================================
+ Hits 13880 13956 +76
+ Misses 1204 1197 -7
Continue to review full report at Codecov.
|
Running oss-check locally gave me better results:
|
@dirtydanee I think some results from oss-check are false-negatives. Some examples:
|
@marcelofabri i will look into soon, i will branch out from your branch and push the changes there. |
@dirtydanee feel free to use your existing branch if you'd prefer - I can close this PR and we could move back to the original one. |
Continued from #2244 (I just rebased and fixed the conflicts introduced by #2313).
All hard work was done by @dirtydanee.