Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit_type_interface when used in statements or in capture groups #2321

Closed
wants to merge 1 commit into from
Closed

Fix explicit_type_interface when used in statements or in capture groups #2321

wants to merge 1 commit into from

Conversation

marcelofabri
Copy link
Collaborator

Continued from #2244 (I just rebased and fixed the conflicts introduced by #2313).

All hard work was done by @dirtydanee.

@SwiftLintBot
Copy link

19717 Messages
📖 Linting Aerial with this PR took 0.41s vs 0.37s on master (10% slower)
📖 Linting Alamofire with this PR took 3.59s vs 3.04s on master (18% slower)
📖 Linting Firefox with this PR took 14.08s vs 11.68s on master (20% slower)
📖 Linting Kickstarter with this PR took 21.37s vs 16.88s on master (26% slower)
📖 Linting Moya with this PR took 2.36s vs 1.85s on master (27% slower)
📖 Linting Nimble with this PR took 2.09s vs 1.63s on master (28% slower)
📖 Linting Quick with this PR took 0.52s vs 0.5s on master (4% slower)
📖 Linting Realm with this PR took 3.88s vs 3.18s on master (22% slower)
📖 Linting SourceKitten with this PR took 1.14s vs 0.97s on master (17% slower)
📖 Linting Sourcery with this PR took 5.05s vs 4.35s on master (16% slower)
📖 Linting Swift with this PR took 30.48s vs 27.17s on master (12% slower)
📖 Linting WordPress with this PR took 15.3s vs 15.21s on master (0% slower)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:20:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/App/AppDelegate.swift:21:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:26:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:28:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/Preferences.swift:49:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:63:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:68:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:76:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:77:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:26:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:29:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:37:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:38:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:43:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:52:29: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:62:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:78:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:110:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:122:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:150:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:161:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:176:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:185:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:198:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:220:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:240:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:249:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:250:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:251:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:270:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:272:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:278:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Extensions/CollectionType+Shuffling.swift:16:14: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Extensions/CollectionType+Shuffling.swift:16:31: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Extensions/CollectionType+Shuffling.swift:19:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:41:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:44:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:45:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:50:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:59:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:80:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:99:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:103:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:104:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:105:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:107:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:114:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:116:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:119:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:120:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:134:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:137:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:138:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:139:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:140:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:170:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:174:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:179:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:184:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:217:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:222:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:64:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:66:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:71:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:91:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:117:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:119:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:122:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:127:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:142:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:154:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:160:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:188:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:199:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:208:27: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:219:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:228:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:241:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:246:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:289:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:294:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Views/CheckCellView.swift:30:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:80:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:103:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:149:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:156:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:186:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:190:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:233:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:234:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:240:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:242:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:274:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:277:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:279:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:314:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:323:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:335:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:338:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:370:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:371:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:377:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:378:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:383:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:384:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:386:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:394:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:395:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:399:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:400:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:404:21: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:412:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:436:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:438:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:441:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:489:19: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:524:16: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:33:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:34:13: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:58:20: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in Aerial: /Users/distiller/project/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:64:23: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
⚠️ Danger found 19717 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 133.

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #2321 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2321      +/-   ##
=========================================
+ Coverage   92.01%   92.1%   +0.08%     
=========================================
  Files         299     299              
  Lines       15084   15153      +69     
=========================================
+ Hits        13880   13956      +76     
+ Misses       1204    1197       -7
Impacted Files Coverage Δ
...rameworkTests/ExplicitTypeInterfaceRuleTests.swift 100% <100%> (ø) ⬆️
...intFramework/Rules/ExplicitTypeInterfaceRule.swift 98.11% <100%> (+1.68%) ⬆️
...iftLintFramework/Extensions/String+SwiftLint.swift 89.65% <0%> (+3.44%) ⬆️
Source/SwiftLintFramework/Models/Linter.swift 85.61% <0%> (+3.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87c4410...4ef1729. Read the comment docs.

@marcelofabri
Copy link
Collaborator Author

Running oss-check locally gave me better results:

Message: Linting Aerial with this PR took 0.3s vs 0.28s on master (7% slower)
Message: Linting Alamofire with this PR took 2.37s vs 2.19s on master (8% slower)
Message: Linting Firefox with this PR took 8.91s vs 8.72s on master (2% slower)
Message: Linting Kickstarter with this PR took 11.67s vs 11.58s on master (0% slower)
Message: Linting Moya with this PR took 1.24s vs 1.19s on master (4% slower)
Message: Linting Nimble with this PR took 1.15s vs 1.18s on master (2% faster)
Message: Linting Quick with this PR took 0.33s vs 0.32s on master (3% slower)
Message: Linting Realm with this PR took 2.32s vs 2.24s on master (3% slower)
Message: Linting SourceKitten with this PR took 0.8s vs 0.74s on master (8% slower)
Message: Linting Sourcery with this PR took 3.23s vs 3.2s on master (0% slower)
Message: Linting Swift with this PR took 20.1s vs 19.84s on master (1% slower)
Message: Linting WordPress with this PR took 10.11s vs 10.36s on master (2% faster)

@dirtydanee
Copy link
Contributor

@marcelofabri i will look into soon, i will branch out from your branch and push the changes there.

@marcelofabri
Copy link
Collaborator Author

@dirtydanee feel free to use your existing branch if you'd prefer - I can close this PR and we could move back to the original one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants